Skip to content

Add ability to toggle glass frame scroll motion #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 8, 2025
Merged

Add ability to toggle glass frame scroll motion #102

merged 6 commits into from
May 8, 2025

Conversation

lfuelling
Copy link
Contributor

@lfuelling lfuelling commented Oct 30, 2024 •
edited
Loading

Hi,

This PR changes the default glass background behavior to be non-moving.
The old behavior can be enabled again by adding a class to the window, I also added another example for this to the documentation (into the "Glass frame & Color" section), so the difference is directly visible.

Thanks

@vercel Vercel
Copy link

vercel bot commented Oct 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
7css ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 4, 2025 10:28am

@lfuelling
add separate class for scroll attachment, use local by default
c021b5f 
Scroll still animates the background when the viewport size changes
@lfuelling lfuelling changed the title Add ability to toggle glass background scroll motion Add ability to toggle glass frame scroll motion Oct 30, 2024
khang-nd
khang-nd requested changes Oct 31, 2024
View reviewed changes
Copy link
Owner

@khang-nd khang-nd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, I actually didn't know much about background-attachment and its implementation, learned something new there 👍

Still, 1 feedback point to improve the guideline.

@lfuelling lfuelling changed the title Add ability to toggle glass frame scroll motion [WIP] Add ability to toggle glass frame scroll motion Oct 31, 2024
@lfuelling
Copy link
Contributor Author

I just found a video in which it seems like fixed would actually be the correct behavior.

I'll have to install Windows 7 myself to verify but in that case I would make fixed the explicit default and update the example just in case someone needs the other behavior.

khang-nd
khang-nd approved these changes Nov 1, 2024
View reviewed changes
Copy link
Owner

@khang-nd khang-nd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, lemme know when it's ready and I'll merge it in.

@khang-nd
Copy link
Owner

khang-nd commented May 1, 2025

Hi @lfuelling, any interest in finalizing it? Otherwise, I might close this as it's been stale for quite a long time.

@lfuelling
Copy link
Contributor Author

Hi, sorry, I kind of forgot that this was still open.
I fixed the docs regarding the correct behavior found in Windows 7, so this can be merged now :)

@lfuelling lfuelling changed the title [WIP] Add ability to toggle glass frame scroll motion Add ability to toggle glass frame scroll motion May 4, 2025
@lfuelling
Copy link
Contributor Author

I managed to get Windows 7 running with Aero, it shows the Aero glass effect is locked to the viewport instead of scrolling with the window frame:

https://youtu.be/uEv6A-XgvAU

@khang-nd
Copy link
Owner

khang-nd commented May 8, 2025

Hi, sorry, I kind of forgot that this was still open. I fixed the docs regarding the correct behavior found in Windows 7, so this can be merged now :)

Not a problem at all, thanks for finalizing it :)

@khang-nd khang-nd merged commit ec9d42c into khang-nd:main May 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khang-nd khang-nd khang-nd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lfuelling @khang-nd