Skip to content

Conversation

lfuelling
Copy link
Contributor

@lfuelling lfuelling commented Dec 19, 2024

Hi,

this PR applies the existing button styles to the file selector button and adds a documentation section about that:

Screenshot of the documentation pages showing the styled file input.

The ::file-selector-button selector is supported by all major browsers.

Thanks

Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
7css ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 4, 2025 10:32am

@lfuelling
Copy link
Contributor Author

lfuelling commented May 4, 2025

Hi, this was open a long time as well, sorry again.

I separated the styles for the file selector, and the other buttons are now usable again, but I'm unable to get the file selector button to work like a proper button (the click and hover states don't work properly).

I'd still be in favor for this being merged, a somewhat styled file selector button is better than an unstyled file selector button imo.

@lfuelling lfuelling requested a review from khang-nd May 9, 2025 09:52
@khang-nd
Copy link
Owner

khang-nd commented Jul 6, 2025

Hey @lfuelling, sorry, I totally missed this! Will have a look and merge it in soon if no issues.

Copy link
Owner

@khang-nd khang-nd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Declaring every style as variable brings unnecessary complexity and maintenance overhead down the track. I still think using the postcss-extend-rule plugin is the better way to do this.

Leave this with me, I'll tackle this in #118. Thanks for the PR, but I'll close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants