Skip to content

mlx - add rgb_to_grayscale #19609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2024
Merged

mlx - add rgb_to_grayscale #19609

merged 1 commit into from
Apr 24, 2024

Conversation

lkarthee
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (mlx@8b7997d). Click here to learn what that means.

Files Patch % Lines
keras/src/backend/mlx/image.py 0.00% 17 Missing ⚠️
Additional details and impacted files 
@@          Coverage Diff           @@
##             mlx   #19609   +/-   ##
======================================
  Coverage       ?   68.52%           
======================================
  Files          ?      506           
  Lines          ?    45896           
  Branches       ?     8484           
======================================
  Hits           ?    31451           
  Misses         ?    12794           
  Partials       ?     1651
Flag Coverage Δ
keras 68.44% <0.00%> (?)
keras-jax 58.91% <0.00%> (?)
keras-numpy 53.23% <0.00%> (?)
keras-tensorflow 60.05% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fchollet
fchollet approved these changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice -- thanks for the PR!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Apr 24, 2024
@fchollet fchollet merged commit bf15326 into keras-team:mlx Apr 24, 2024
@google-ml-butler google-ml-butler bot removed ready to pull Ready to be merged into the codebase kokoro:force-run labels Apr 24, 2024
@lkarthee lkarthee deleted the image_fix branch April 25, 2024 02:36
@lkarthee lkarthee mentioned this pull request May 2, 2024
Open
62 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchollet fchollet fchollet approved these changes

Assignees

@gbaned gbaned

Labels
size:S
Projects
PR Queue
Status: Assigned Reviewer
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lkarthee @codecov-commenter @fchollet @gbaned