Skip to content

mlx - add argpartition to numpy #19680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2024
Merged

mlx - add argpartition to numpy #19680

merged 1 commit into from
May 7, 2024

Conversation

lkarthee
Copy link
Contributor

@lkarthee lkarthee commented May 7, 2024

No description provided.

@lkarthee lkarthee mentioned this pull request May 7, 2024
Open
62 tasks
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (mlx@ad948c2). Click here to learn what that means.

Files Patch % Lines
keras/src/backend/mlx/numpy.py 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@          Coverage Diff           @@
##             mlx   #19680   +/-   ##
======================================
  Coverage       ?   75.54%           
======================================
  Files          ?      508           
  Lines          ?    47225           
  Branches       ?     8686           
======================================
  Hits           ?    35675           
  Misses         ?     9808           
  Partials       ?     1742
Flag Coverage Δ
keras 75.39% <0.00%> (?)
keras-jax 59.76% <0.00%> (?)
keras-numpy 54.31% <0.00%> (?)
keras-tensorflow 61.07% <0.00%> (?)
keras-torch 59.78% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gbaned gbaned requested a review from fchollet May 7, 2024 04:10
fchollet
fchollet approved these changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels May 7, 2024
@fchollet fchollet merged commit 1f9139c into keras-team:mlx May 7, 2024
@google-ml-butler google-ml-butler bot removed awaiting review ready to pull Ready to be merged into the codebase kokoro:force-run labels May 7, 2024
@lkarthee lkarthee deleted the argpartition branch May 8, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchollet fchollet fchollet approved these changes

Assignees

@gbaned gbaned

Labels
size:XS
Projects
PR Queue
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lkarthee @codecov-commenter @fchollet @gbaned