Skip to content
This repository was archived by the owner on Dec 21, 2023. It is now read-only.

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Jun 7, 2022

Signed-off-by: odubajDT ondrej.dubaj@dynatrace.com

This PR

  • refactors git remote repository credentials models to be mutable from only one place

GitUser string `json:"gitUser,omitempty"`

// https git credentials
HttpsAuth *HttpsGitAuth `json:"https,omitempty"`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golint] reported by reviewdog 🐶
struct field HttpsAuth should be HTTPSAuth

HttpsAuth *HttpsGitAuth `json:"https,omitempty"`

//ssh git credentials
SshAuth *SshGitAuth `json:"ssh,omitempty"`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golint] reported by reviewdog 🐶
struct field SshAuth should be SSHAuth

}

// HttpsGitAuth stores HTTPS git credentials
type HttpsGitAuth struct {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golint] reported by reviewdog 🐶
type HttpsGitAuth should be HTTPSGitAuth

}

// SshGitAuth stores SSH git credentials
type SshGitAuth struct {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golint] reported by reviewdog 🐶
type SshGitAuth should be SSHGitAuth

GitUser string `json:"gitUser,omitempty"`

// https git credentials
HttpsAuth *HttpsGitAuthSecure `json:"https,omitempty"`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golint] reported by reviewdog 🐶
struct field HttpsAuth should be HTTPSAuth


// HttpsGitAuthSecure stores HTTPS git credentials without secure information
// model for retrieving credentials data with GET request
type HttpsGitAuthSecure struct {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golint] reported by reviewdog 🐶
type HttpsGitAuthSecure should be HTTPSGitAuthSecure

RealAnna
RealAnna previously approved these changes Jun 9, 2022
Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bacherfl
bacherfl previously approved these changes Jun 9, 2022
@odubajDT odubajDT force-pushed the feat/7963/refactor-auth-model branch from 1c949dd to ea3f2d0 Compare June 9, 2022 10:09
User string `json:"user,omitempty" bson:"user"`

// https git credentials
HttpsAuth *HttpsGitAuthSecure `json:"https,omitempty" bson:"https"`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golint] reported by reviewdog 🐶
struct field HttpsAuth should be HTTPSAuth

@odubajDT odubajDT force-pushed the feat/7963/refactor-auth-model branch from f3513cd to 305c59d Compare June 28, 2022 06:37
odubajDT added 6 commits June 28, 2022 09:08
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT odubajDT force-pushed the feat/7963/refactor-auth-model branch from 305c59d to 3c0958f Compare June 28, 2022 07:09
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odubajDT odubajDT merged commit fc5b6f9 into master Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants