-
Notifications
You must be signed in to change notification settings - Fork 12
feat: Refactor git remote repository credentials models #475
Conversation
pkg/api/models/git_credentials.go
Outdated
GitUser string `json:"gitUser,omitempty"` | ||
|
||
// https git credentials | ||
HttpsAuth *HttpsGitAuth `json:"https,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[golint] reported by reviewdog 🐶
struct field HttpsAuth should be HTTPSAuth
pkg/api/models/git_credentials.go
Outdated
HttpsAuth *HttpsGitAuth `json:"https,omitempty"` | ||
|
||
//ssh git credentials | ||
SshAuth *SshGitAuth `json:"ssh,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[golint] reported by reviewdog 🐶
struct field SshAuth should be SSHAuth
} | ||
|
||
// HttpsGitAuth stores HTTPS git credentials | ||
type HttpsGitAuth struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[golint] reported by reviewdog 🐶
type HttpsGitAuth should be HTTPSGitAuth
} | ||
|
||
// SshGitAuth stores SSH git credentials | ||
type SshGitAuth struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[golint] reported by reviewdog 🐶
type SshGitAuth should be SSHGitAuth
pkg/api/models/git_credentials.go
Outdated
GitUser string `json:"gitUser,omitempty"` | ||
|
||
// https git credentials | ||
HttpsAuth *HttpsGitAuthSecure `json:"https,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[golint] reported by reviewdog 🐶
struct field HttpsAuth should be HTTPSAuth
|
||
// HttpsGitAuthSecure stores HTTPS git credentials without secure information | ||
// model for retrieving credentials data with GET request | ||
type HttpsGitAuthSecure struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[golint] reported by reviewdog 🐶
type HttpsGitAuthSecure should be HTTPSGitAuthSecure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1c949dd
to
ea3f2d0
Compare
User string `json:"user,omitempty" bson:"user"` | ||
|
||
// https git credentials | ||
HttpsAuth *HttpsGitAuthSecure `json:"https,omitempty" bson:"https"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[golint] reported by reviewdog 🐶
struct field HttpsAuth should be HTTPSAuth
f3513cd
to
305c59d
Compare
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
305c59d
to
3c0958f
Compare
Kudos, SonarCloud Quality Gate passed!
|
Signed-off-by: odubajDT ondrej.dubaj@dynatrace.com
This PR