Skip to content

Fix Bucket #1159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Jan 24, 2024
Merged

Fix Bucket #1159

merged 17 commits into from
Jan 24, 2024

Conversation

FusionBolt
Copy link
Contributor

@FusionBolt FusionBolt commented Jan 18, 2024 •
edited
Loading

  1. fix s2b b2s importer
  2. fix ShouldBeRestore
  3. fix bucket pipeline
  4. add swish ShapeEvaluator
  5. add some marker rule

@FusionBolt FusionBolt closed this Jan 18, 2024
@FusionBolt FusionBolt reopened this Jan 18, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 18, 2024 •
edited
Loading

Test Results

5 937 tests  +78   5 937 ✅ +78   8m 20s ⏱️ +9s
    6 suites ± 0       0 💤 ± 0 
    6 files   ± 0       0 ❌ ± 0 

Results for commit c191a40. ± Comparison against base commit 9647756.

This pull request removes 18 and adds 96 tests. Note that renamed tests count towards both. 
tests.importer.onnx_.basic.test_transpose ‑ test_transpose[axis0-in_shape0]
tests.importer.onnx_.basic.test_transpose ‑ test_transpose[axis0-in_shape1]
tests.importer.onnx_.basic.test_transpose ‑ test_transpose[axis0-in_shape2]
tests.importer.onnx_.basic.test_transpose ‑ test_transpose[axis1-in_shape0]
tests.importer.onnx_.basic.test_transpose ‑ test_transpose[axis1-in_shape1]
tests.importer.onnx_.basic.test_transpose ‑ test_transpose[axis1-in_shape2]
tests.importer.onnx_.basic.test_transpose ‑ test_transpose[axis2-in_shape0]
tests.importer.onnx_.basic.test_transpose ‑ test_transpose[axis2-in_shape1]
tests.importer.onnx_.basic.test_transpose ‑ test_transpose[axis2-in_shape2]
tests.importer.onnx_.basic.test_transpose ‑ test_transpose[axis3-in_shape0]
…

tests.importer.onnx_.basic.test_transpose ‑ test_transpose[1-None-in_shape0]
tests.importer.onnx_.basic.test_transpose ‑ test_transpose[1-None-in_shape1]
tests.importer.onnx_.basic.test_transpose ‑ test_transpose[1-None-in_shape2]
tests.importer.onnx_.basic.test_transpose ‑ test_transpose[1-axis1-in_shape0]
tests.importer.onnx_.basic.test_transpose ‑ test_transpose[1-axis1-in_shape1]
tests.importer.onnx_.basic.test_transpose ‑ test_transpose[1-axis1-in_shape2]
tests.importer.onnx_.basic.test_transpose ‑ test_transpose[1-axis10-in_shape0]
tests.importer.onnx_.basic.test_transpose ‑ test_transpose[1-axis10-in_shape1]
tests.importer.onnx_.basic.test_transpose ‑ test_transpose[1-axis10-in_shape2]
tests.importer.onnx_.basic.test_transpose ‑ test_transpose[1-axis11-in_shape0]
…

♻️ This comment has been updated with latest results.

@codecov Codecov
Copy link

codecov bot commented Jan 18, 2024 •
edited
Loading

Codecov Report

Attention: 48 lines in your changes are missing coverage. Please review.

Comparison is base (3331d2d) 72.88% compared to head (c191a40) 73.11%.
Report is 1 commits behind head on master.

Files Patch % Lines
...ncase.Passes/Rules/WithMarker/CombineReshapePad.cs 53.06% 23 Missing ⚠️
src/Nncase.Passes/Rules/ShapeBucket/ShapeBucket.cs 45.00% 8 Missing and 3 partials ⚠️
...ase.EGraph/Passes/EGraphExtractors/SatExtractor.cs 16.66% 5 Missing ⚠️
src/Nncase.Importer/TFLite/SpaceToBatchND.cs 16.66% 3 Missing and 2 partials ⚠️
...c/Nncase.Passes/Rules/Neutral/FoldDilatedConv2D.cs 0.00% 2 Missing ⚠️
src/Nncase.Compiler/Compiler.cs 91.66% 1 Missing ⚠️
src/Nncase.Evaluator/NN/Activations.cs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1159      +/-   ##
==========================================
+ Coverage   72.88%   73.11%   +0.22%     
==========================================
  Files         706      707       +1     
  Lines       25930    26007      +77     
  Branches     4228     4244      +16     
==========================================
+ Hits        18899    19014     +115     
+ Misses       6386     6347      -39     
- Partials      645      646       +1
Flag Coverage Δ
integration 39.23% <47.74%> (+0.26%) ⬆️
unit 64.58% <18.91%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sunnycase
sunnycase reviewed Jan 19, 2024
View reviewed changes
@FusionBolt FusionBolt closed this Jan 19, 2024
@FusionBolt FusionBolt reopened this Jan 19, 2024
@FusionBolt FusionBolt closed this Jan 19, 2024
@FusionBolt FusionBolt reopened this Jan 19, 2024
@FusionBolt FusionBolt closed this Jan 24, 2024
@FusionBolt FusionBolt reopened this Jan 24, 2024
@FusionBolt FusionBolt merged commit de6c89d into master Jan 24, 2024
@FusionBolt FusionBolt deleted the fix/bucket branch January 24, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunnycase sunnycase sunnycase left review comments

@zhangyang2057 zhangyang2057 zhangyang2057 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FusionBolt @sunnycase @zhangyang2057