Skip to content

Fix/melgan #1126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Nov 17, 2023
Merged

Fix/melgan #1126

merged 32 commits into from
Nov 17, 2023

Conversation

FusionBolt
Copy link
Contributor

@FusionBolt FusionBolt commented Nov 14, 2023 •
edited
Loading

  1. add FoldDilatedConv2D
  2. add SwapBinaryArg
  3. FoldTransposeActTranspose
  4. add marker for some rule
  5. fix ShapeBucket
  6. fix 3D SpaceToBatch and BatchToSpace

@FusionBolt FusionBolt closed this Nov 14, 2023
@FusionBolt FusionBolt reopened this Nov 14, 2023
@FusionBolt FusionBolt closed this Nov 14, 2023
@FusionBolt FusionBolt reopened this Nov 14, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 15, 2023 •
edited
Loading

Test Results

5 859 tests  ±0   5 859 ✔️ ±0   7m 24s ⏱️ -23s
       6 suites ±0          0 💤 ±0 
       6 files   ±0          0 ❌ ±0 

Results for commit ae2a0ba. ± Comparison against base commit 5364b01.

♻️ This comment has been updated with latest results.

@codecov Codecov
Copy link

codecov bot commented Nov 15, 2023 •
edited
Loading

Codecov Report

Attention: 314 lines in your changes are missing coverage. Please review.

Comparison is base (5364b01) 73.93% compared to head (2782ab9) 73.38%.

❗ Current head 2782ab9 differs from pull request most recent head ae2a0ba. Consider uploading reports for the commit ae2a0ba to get more accurate results

Files Patch % Lines
...Nncase.Passes/Rules/WithMarker/CombineTranspose.cs 0.00% 124 Missing ⚠️
...c/Nncase.Passes/Rules/Neutral/FoldDilatedConv2D.cs 0.00% 104 Missing ⚠️
src/Nncase.Passes/Rules/ShapeBucket/ShapeBucket.cs 73.21% 22 Missing and 8 partials ⚠️
src/Nncase.Importer/TFLite/SpaceToBatchND.cs 12.50% 12 Missing and 2 partials ⚠️
src/Nncase.Evaluator/NN/SpaceToBatch.cs 58.33% 5 Missing and 5 partials ⚠️
src/Nncase.Passes/Rules/Neutral/SwapBinaryArgs.cs 0.00% 8 Missing ⚠️
...case.Passes/Rules/ShapeBucket/ShapeBucketHelper.cs 66.66% 7 Missing ⚠️
...case.Passes/Rules/ShapeBucket/MergeBucketFusion.cs 0.00% 6 Missing ⚠️
...case.Passes/Rules/ShapeBucket/RecordFusionShape.cs 73.68% 3 Missing and 2 partials ⚠️
src/Nncase.Evaluator/EvaluatorDumpManager.cs 25.00% 1 Missing and 2 partials ⚠️
... and 3 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1126      +/-   ##
==========================================
- Coverage   73.93%   73.38%   -0.56%     
==========================================
  Files         704      707       +3     
  Lines       25435    25735     +300     
  Branches     4138     4181      +43     
==========================================
+ Hits        18806    18885      +79     
- Misses       6000     6216     +216     
- Partials      629      634       +5
Flag Coverage Δ
integration 39.17% <1.93%> (-0.46%) ⬇️
unit 65.24% <31.89%> (-0.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FusionBolt FusionBolt merged commit 3820af1 into master Nov 17, 2023
@FusionBolt FusionBolt deleted the fix/melgan branch November 17, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curioyang curioyang curioyang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FusionBolt @curioyang