Skip to content

Fix GetItem #1114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2023
Merged

Fix GetItem #1114

merged 2 commits into from
Oct 30, 2023

Conversation

FusionBolt
Copy link
Contributor

@FusionBolt FusionBolt commented Oct 30, 2023 •
edited
Loading

fix bug for GetItem kernels

@FusionBolt FusionBolt closed this Oct 30, 2023
@FusionBolt FusionBolt reopened this Oct 30, 2023
@github-actions
Copy link

github-actions bot commented Oct 30, 2023 •
edited
Loading

Test Results

5 831 tests  ±0   5 831 ✔️ ±0   9m 39s ⏱️ -10s
       6 suites ±0          0 💤 ±0 
       6 files   ±0          0 ❌ ±0 

Results for commit d768420. ± Comparison against base commit ef3d74f.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Oct 30, 2023 •
edited
Loading

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (edde68e) 79.22% compared to head (d768420) 76.69%.
Report is 11 commits behind head on release/2.0.

Additional details and impacted files 
@@               Coverage Diff               @@
##           release/2.0    #1114      +/-   ##
===============================================
- Coverage        79.22%   76.69%   -2.54%     
===============================================
  Files              689      689              
  Lines            24267    24664     +397     
  Branches             0     4005    +4005     
===============================================
- Hits             19226    18915     -311     
- Misses            5041     5129      +88     
- Partials             0      620     +620
Flag Coverage Δ
integration 40.10% <57.50%> (-0.98%) ⬇️
unit 68.65% <41.25%> (-3.58%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...odules.StackVM/CodeGen/StackVM/CodeGenVisitor.g.cs 64.92% <ø> (ø)
...les.StackVM/CodeGen/StackVM/StackVMLinkedModule.cs 100.00% <100.00%> (ø)
src/Nncase.Core/Quantization/QuantizeOptions.cs 100.00% <100.00%> (ø)
src/Nncase.Importer/Onnx/Conv2D.cs 69.23% <100.00%> (-7.86%) ⬇️
src/Nncase.Importer/Onnx/Gemm.cs 80.00% <100.00%> (-8.89%) ⬇️
src/Nncase.Importer/Onnx/MatMul.cs 100.00% <100.00%> (ø)
src/Nncase.Importer/Onnx/ReduceWindow2D.cs 74.19% <ø> (-9.68%) ⬇️
src/Nncase.Importer/TFLite/Activations.cs 72.41% <100.00%> (+3.18%) ⬆️
src/Nncase.Importer/TFLite/Binary.cs 66.66% <100.00%> (+23.80%) ⬆️
src/Nncase.Importer/TFLite/Conv2DTranspose.cs 100.00% <100.00%> (ø)
... and 8 more

... and 187 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FusionBolt FusionBolt changed the title fix runtime Fix GetItem Oct 30, 2023
@FusionBolt FusionBolt changed the base branch from master to release/2.0 October 30, 2023 06:55
@zhangyang2057 zhangyang2057 changed the base branch from release/2.0 to master October 30, 2023 07:12
@FusionBolt FusionBolt changed the base branch from master to release/2.0 October 30, 2023 07:17
@FusionBolt FusionBolt merged commit 390b827 into release/2.0 Oct 30, 2023
@FusionBolt FusionBolt deleted the fix-runtime branch October 30, 2023 08:09
@FusionBolt FusionBolt restored the fix-runtime branch October 30, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@FusionBolt