Implement #1972: Add ability to expire entries from context menus #8731
Conversation
9728398 to
c23dab8
Compare
|
That icon looks too much like delete, we also try to avoid the filled icons. |
I agree that it's too close; here it is with the timer-alert-outline icon if you're interested: The other thought I had was to make it the central X with no circle, but that's probably too close as well. I pushed the icon change, but I'm happy to leave it iconless or whatever is preferred. |
|
Oh I like the clock one! In all technicality there is no need for a "NOW" preset. Unchecking and checking the expire box sets the datetime to now. |
Codecov ReportBase: 64.45% // Head: 64.34% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #8731 +/- ##
===========================================
- Coverage 64.45% 64.34% -0.11%
===========================================
Files 341 341
Lines 44247 44315 +68
===========================================
- Hits 28518 28512 -6
- Misses 15729 15803 +74
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Oh cool, somehow I never noticed that. I've taken it out to keep things simple. |
f1b7952 to
febca9e
Compare
febca9e to
43915ec
Compare
Closes #1972 Add ability to immediately expire an entry from the context menu --------- Co-authored-by: Jonathan White <support@dmapps.us>
Closes keepassxreboot#1972 Add ability to immediately expire an entry from the context menu --------- Co-authored-by: Jonathan White <support@dmapps.us>
Closes keepassxreboot#1972 Add ability to immediately expire an entry from the context menu --------- Co-authored-by: Jonathan White <support@dmapps.us>
Implements #1972. I think it needs an action to unexpire as well, since the user could get into trouble quickly if they accidentally expire a bunch of things. I'll stick both in a submenu to reduce clutter if I do it.
I took the liberty of making an icon for the expire action out of the expired status svg, at least as a recognizable placeholder. If that's not good long-term, I was eyeing Material Design's timer-alert-outline, but I didn't want to deviate from what was already there.The icon for the expire action is timer-alert-outline.In the reports, I ran into an issue with getting the context menu action to show "Expire entry" for a single item and "Expire entries" for multiple selected like the other actions. Whatever magic the other actions are using, I couldn't find it. See screenshots.
Screenshots
Note that icon has been changed since I took these -- see screenshot lower in comments.
Top menu:
Database widget:
Health Check Report:
HIBP report:
Testing strategy
Manual testing (so far)
Type of change