Revert async Access Confirm Dialog #8665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
765bf3c to
8374bb7
Compare
phoerious
approved these changes
Oct 26, 2022
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8665 +/- ##
===========================================
+ Coverage 64.29% 64.39% +0.10%
===========================================
Files 341 341
Lines 44336 44242 -94
===========================================
- Hits 28503 28488 -15
+ Misses 15833 15754 -79 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
8374bb7 to
dd4c3d5
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #8273 because it clearly does not work properly on every operating system. This feature must be remade.
Fixes #8634.
Type of change