Fix deleting existing socket file before making a new symbolic link #8656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droidmonkey
approved these changes
Oct 25, 2022
phoerious
approved these changes
Oct 25, 2022
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8656 +/- ##
===========================================
- Coverage 64.30% 64.28% -0.01%
===========================================
Files 341 341
Lines 44330 44331 +1
===========================================
- Hits 28502 28496 -6
- Misses 15828 15835 +7 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Merged
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the old socket before making a new symbolic link. Qt's function does not force it, and it does nothing if the target file already exists. Introduced in #8030.
Fixes #8634.
Type of change