Skip to content

Fix entry notes reveal button requiring two clicks sometimes #11351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2024
Merged

Fix entry notes reveal button requiring two clicks sometimes #11351

merged 1 commit into from
Oct 14, 2024

Conversation

droidmonkey
Copy link
Member

Related to discussion in #11345

Testing strategy

Tested manually

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@droidmonkey droidmonkey added this to the v2.7.10 milestone Oct 11, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.71%. Comparing base (740994e) to head (2f80b16).
Report is 29 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #11351      +/-   ##
===========================================
- Coverage    63.71%   63.71%   -0.00%     
===========================================
  Files          362      362              
  Lines        38000    38001       +1     
===========================================
  Hits         24211    24211              
- Misses       13789    13790       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@varjolintu
Copy link
Member

Found this while testing this: #11352

@varjolintu
Copy link
Member

varjolintu commented Oct 12, 2024 •
edited
Loading

Also found the following when debugging with ASAN enabled. Can you verify this happens to you too?

  1. Edit entry, modify the note.
  2. Press Apply and then OK.
  3. Save the database -> ASAN hits a breakpoint.
  4. If doing the same without Apply, everything is ok.

ASAN shows:

error: <user expression 1>:1:1: use of undeclared identifier 'username'    1 | username.d | ^

lldb) thread info -s
thread #7: tid = 0x2239c, 0x0000000106c65060 libclang_rt.asan_osx_dynamic.dylib`__asan::AsanDie(), name = 'Thread (pooled)', stop reason = Invalid memory access

{
  "access_size": 32,
  "access_type": 1,
  "address": 4387995934,
  "description": "unknown-crash",
  "instrumentation_class": "AddressSanitizer",
  "pc": 4408505784,
  "stop_type": "fatal_error"
}

And the call stack:

__asan::AsanDie() 0x0000000106c65060
SymmetricCipher::finish(QByteArray &) SymmetricCipher.cpp:115
SymmetricCipherStream::writeBlock(bool) SymmetricCipherStream.cpp:209
SymmetricCipherStream::reset() SymmetricCipherStream.cpp:69
Kdbx4Writer::writeDatabase(QIODevice *, Database *) Kdbx4Writer.cpp:177
KeePass2Writer::writeDatabase(QIODevice *, Database *) KeePass2Writer.cpp:140
Database::writeDatabase(QIODevice *, QString *) Database.cpp:419
Database::performSave(const QString &, Database::SaveAction, const QString &, QString *) Database.cpp:329
$_6::operator()() const Database.cpp:292

@droidmonkey
Copy link
Member Author

If that was an issue it should come up in our CI tests which all run ASAN

@droidmonkey droidmonkey merged commit 0288188 into develop Oct 14, 2024
11 checks passed
@droidmonkey droidmonkey deleted the fix/hide-notes-button branch October 14, 2024 13:56
@phoerious phoerious added pr: bugfix Pull request fixes a bug and removed bug labels Nov 22, 2024
@droidmonkey droidmonkey added the pr: backported Pull request backported to previous release label Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varjolintu varjolintu varjolintu approved these changes

Assignees
No one assigned
Labels
pr: backported Pull request backported to previous release pr: bugfix Pull request fixes a bug user interface
Projects
None yet
Milestone
v2.7.10
Development

Successfully merging this pull request may close these issues.
3 participants
@droidmonkey @varjolintu @phoerious