require race condition check for PRs to pass #6778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
|
/skip-e2e |
There was a problem hiding this comment.
Pull Request Overview
This PR enforces that the race detector step in CI must pass before merging by removing the previous continue-on-error allowance.
- Removed the
continue-on-error: truesetting so race detector failures will now block PR merges. - Ensures that any introduced race conditions must be addressed immediately.
Comments suppressed due to low confidence (1)
.github/workflows/pr-validation.yml:72
- This comment is now outdated since race detector failures will block PRs. Please update or remove it to accurately reflect that the
make test-racestep is now required.
# there are good number of race conditions currently in KEDA, don't block the development for this
JorTurFer
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6760 enabled the race condition detector for unit tests but not required to pass for PRs to merge. Since it currently reports no failures, I would like to propose this to be a binding requirement for PR to merge.
closes: #6761