Skip to content

chore: Remove deprecated AAD-Pod-Identity and AWS-KIAM auths #5782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 7, 2024
Merged

chore: Remove deprecated AAD-Pod-Identity and AWS-KIAM auths #5782

merged 3 commits into from
May 7, 2024

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented May 4, 2024 •
edited
Loading

Both auth were deprecated and we have to remove it for v2.15.
I know there are still some references to ActiveDirectoyEndpoint which aren't directly required either because we won't support aad-pod-identity anymore. They will be removed as part of this other PR that supports new SDKs and the merge conflicts will already be terrible without removing more fields than the strictly required on this PR

Checklist

  • Changelog has been updated and is aligned with our changelog requirements
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #5035
Fixes #5085

@JorTurFer
chore: Remove deprecated AAD-Pod-Identity and AWS-KIAM auths
3be040a 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer requested a review from a team as a code owner May 4, 2024 13:19
@JorTurFer
Copy link
Member Author

JorTurFer commented May 4, 2024 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

JorTurFer added 2 commits May 4, 2024 15:45
@JorTurFer
fix CI
2e45661 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
fix CI
362b9c1 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
This was referenced May 4, 2024
Merged
Merged
@JorTurFer
Copy link
Member Author

JorTurFer commented May 4, 2024 •
edited by github-actions bot
Loading

/run-e2e azure
Update: You can check the progress here

@JorTurFer JorTurFer merged commit ed69b41 into kedacore:main May 7, 2024
@JorTurFer JorTurFer deleted the remove-deprecations branch May 7, 2024 20:23
@vladimirglazkov
Copy link

Hey @JorTurFer !
There is an announcement that AAD Pod Identity support will be removed in 2.15.
https://keda.sh/docs/2.14/authentication-providers/azure-ad-pod-identity/
So why did you remove it in 2.14?

@JorTurFer
Copy link
Member Author

JorTurFer commented Jun 24, 2024 •
edited
Loading

So why did you remove it in 2.14?

What do you mean? v2.14 still has support for it: https://github.com/kedacore/keda/blob/release/v2.14/pkg/scalers/azure/azure_aad_podidentity.go

We have just removed it from the main branch, but it means that next version won't have it. Are you using ´main´ tag?

@vladimirglazkov
Copy link

So why did you remove it in 2.14?

What do you mean? v2.14 still has support for it: https://github.com/kedacore/keda/blob/release/v2.14/pkg/scalers/azure/azure_aad_podidentity.go

We have just removed it from the main branch, but it means that next version won't have it. Are you using ´main´ tag?

I've spent some time on researching and figure it out.
kedacore/charts#625

We have Keda installed in another namespace than we're watching into, so the resolution was to add that namespace to watchNamespace parameter. Sorry for bothering you!

We're also migration to Workload Identity and the error triggered me to think that it might be related to the change.

@jkyros jkyros mentioned this pull request Aug 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removing support for AWS-KIAM Identity authentication from KEDA on v2.15 Removing support for Azure AD Pod Identity authentication from KEDA on v2.15
3 participants
@JorTurFer @vladimirglazkov @zroubalik