add `InitialCooldownPeriod` for ScaledObjects #5478

xrwang8 · 2024-02-04T09:31:52Z

… of CooldownPeriod

·

Add a new field InitialDelayCooldownPeriod The purpose of adding a new field InitialDelayCooldownPeriod is to delay the effective time of the CooldownPeriod, so that when the service is started for the first time, it needs to wait for the time of InitialDelayCooldownPeriod to expire before destroying the service.

Checklist

When introducing a new scaler, I agree with the scaling governance policy
I have verified that my change is according to the deprecations & breaking changes policy
Tests have been added
Changelog has been updated and is aligned with our changelog requirements

Fixes #5008

Relates to #

JorTurFer

Thanks for the contribution!
Looking good! I've kept some comments inline, but as global comment, could you add some coverage to the change? Maybe an e2e test or maybe unit test

pkg/scaling/executor/scale_executor.go

pkg/scaling/scale_handler.go

shubham-kaushal · 2024-02-26T15:27:49Z

Hi, @JorTurFer is this PR getting merged anytime soon? Our current workaround for handling the delay at the time of deployment is causing challenges. This feature will be very helpful for many of our use cases.

JorTurFer · 2024-02-26T15:38:07Z

Hi, @JorTurFer is this PR getting merged anytime soon? Our current workaround for handling the delay at the time of deployment is causing challenges. This feature will be very helpful for many of our use cases.

I hope so, but the feature isn't ready to merge yet because test coverage is required. IDK the state of it, @xrwang8 ?

xrwang8 · 2024-02-28T07:51:25Z

I've added e2e testing. @JorTurFer

xrwang8 · 2024-03-04T11:32:15Z

What's wrong with that now @JorTurFer

shubham-kaushal · 2024-03-05T11:52:32Z

Hi @JorTurFer , could you plz. check this PR. E2E test has been added by @xrwang8

JorTurFer · 2024-03-12T21:42:46Z

/run-e2e initial_delay_cooldownperiod
Update: You can check the progress here

tests/internals/initial_delay_cooldownperiod/initial_delay_cooldownperiod_test.go

JorTurFer · 2024-03-12T21:51:06Z

Hi @JorTurFer , could you plz. check this PR. E2E test has been added by @xrwang8

Sorry, I've been quite disconnected :( I have left some comments inline. Apart from them ,we need to fix DCO check for merging the PR, you can find the steps to fix it in the check itself

…f CooldownPeriod and e2e Signed-off-by: wangxingrui <xrwang8@gamil.com>

Signed-off-by: wangxingrui <xrwang8@gamil.com>

xrwang8 · 2024-03-13T09:31:30Z

I have simplified e2e @JorTurFer

JorTurFer

LGTM!
Thanks for the improvement!

JorTurFer · 2024-03-15T23:09:58Z

/run-e2e internal
Update: You can check the progress here

JorTurFer · 2024-03-15T23:10:37Z

Could you open a PR against docs repo too, adding this new parameter to the ScaledObject docs?

xrwang8 · 2024-03-17T06:30:36Z

Could you open a PR against docs repo too, adding this new parameter to the ScaledObject docs?

ok

xrwang8 · 2024-03-18T01:58:54Z

I have modified the document kedacore/keda-docs#1337 @JorTurFer

JorTurFer · 2024-03-25T22:02:13Z

I have modified the document kedacore/keda-docs#1337 @JorTurFer

Let me check them, sorry for the delay... last week was KubeCon EU

JorTurFer

LGTM!
Could you add a record in changelog.md file too? I think that #New section is the best place for this feature

…eter to ScaledObject Signed-off-by: wangxingrui <xrwang8@gamil.com>

Signed-off-by: wangxingrui <xrwang8@gamil.com>

xrwang8 · 2024-03-26T01:50:02Z

LGTM! Could you add a record in changelog.md file too? I think that #New section is the best place for this feature

i hava already done @JorTurFer

CHANGELOG.md

Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>

JorTurFer · 2024-03-26T18:43:39Z

/run-e2e internal
Update: You can check the progress here

JorTurFer · 2024-03-26T19:30:12Z

@zroubalik PTAL

xrwang8 · 2024-04-02T13:18:30Z

What is the current status of this PR? @JorTurFer

JorTurFer · 2024-04-03T20:30:33Z

What is the current status of this PR?

It's ready to merge IMHO, but I'd like to read @zroubalik thoughts too :)

aj-ya · 2024-04-08T12:34:20Z

Hey! @zroubalik , could you please take a look at this. This will save a bit of development for us. Thank you.
cc: @JorTurFer

CHANGELOG.md

apis/keda/v1alpha1/scaledobject_types.go

Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: xrwang <68765051+xrwang8@users.noreply.github.com>

Signed-off-by: wangxingrui <xrwang8@gmail.com>

xrwang8 · 2024-04-11T01:34:51Z

@zroubalik done

Signed-off-by: xrwang <68765051+xrwang8@users.noreply.github.com>

Signed-off-by: wangxingrui <xrwang8@gmail.com>

zroubalik · 2024-04-11T12:09:43Z

/run-e2e internals
Update: You can check the progress here

xrwang8 · 2024-04-12T01:24:12Z

@JorTurFer can it be merged ?

xrwang8 requested a review from a team as a code owner February 4, 2024 09:31

JorTurFer reviewed Feb 9, 2024

View reviewed changes

pkg/scaling/executor/scale_executor.go Outdated Show resolved Hide resolved

pkg/scaling/scale_handler.go Outdated Show resolved Hide resolved

JorTurFer reviewed Mar 12, 2024

View reviewed changes

tests/internals/initial_delay_cooldownperiod/initial_delay_cooldownperiod_test.go Outdated Show resolved Hide resolved

tests/internals/initial_delay_cooldownperiod/initial_delay_cooldownperiod_test.go Outdated Show resolved Hide resolved

xrwang8 closed this Mar 13, 2024

xrwang8 reopened this Mar 13, 2024

wangxingrui and others added 2 commits March 13, 2024 16:15

add new a filed InitialDelayCooldownPeriod delay the effective time o…

fb1f901

…f CooldownPeriod and e2e Signed-off-by: wangxingrui <xrwang8@gamil.com>

test:simplify initial-delay-cooldownperiod e2e test

cecbf7a

Signed-off-by: wangxingrui <xrwang8@gamil.com>

JorTurFer approved these changes Mar 15, 2024

View reviewed changes

Merge branch 'main' into main

333cbfa

xrwang8 requested a review from JorTurFer March 17, 2024 13:47

xrwang8 mentioned this pull request Mar 18, 2024

Added initialDelayCooldownPeriod parameter to KEDA ScaledObject Doc kedacore/keda-docs#1337

Merged

1 task

JorTurFer approved these changes Mar 25, 2024

View reviewed changes

xrwang8 and others added 3 commits March 26, 2024 09:16

Merge branch 'kedacore:main' into main

998eaed

Add entry to CHANGELOG.md for adding initialDelayCooldownPeriod param…

4a2a8db

…eter to ScaledObject Signed-off-by: wangxingrui <xrwang8@gamil.com>

mend

0e8b394

Signed-off-by: wangxingrui <xrwang8@gamil.com>

JorTurFer reviewed Mar 26, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Update CHANGELOG.md

5fae394

Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>

JorTurFer requested a review from zroubalik March 26, 2024 19:30

zroubalik reviewed Apr 10, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

apis/keda/v1alpha1/scaledobject_types.go Outdated Show resolved Hide resolved

xrwang8 and others added 2 commits April 11, 2024 09:00

Update CHANGELOG.md

97eacb9

Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: xrwang <68765051+xrwang8@users.noreply.github.com>

refactor: rename InitialDelayCooldownPeriod to InitialCooldownPeriod

52839d5

Signed-off-by: wangxingrui <xrwang8@gmail.com>

Merge branch 'main' into main

b49d01d

Signed-off-by: xrwang <68765051+xrwang8@users.noreply.github.com>

xrwang8 changed the title ~~add new a filed InitialDelayCooldownPeriod delay the effective time…~~ add new a filed InitialCooldownPeriod delay the effective time… Apr 11, 2024

xrwang8 added 2 commits April 11, 2024 14:31

Update CHANGELOG to sort entries according to project requirements

092f868

Signed-off-by: wangxingrui <xrwang8@gmail.com>

Change InitialCooldownPeriod from pointer to non-pointer int32

fc58691

Signed-off-by: wangxingrui <xrwang8@gmail.com>

Merge branch 'main' into main

e407837

zroubalik changed the title ~~add new a filed InitialCooldownPeriod delay the effective time…~~ add InitialCooldownPeriod for ScaledObjects Apr 12, 2024

zroubalik approved these changes Apr 12, 2024

View reviewed changes

zroubalik merged commit 80806a7 into kedacore:main Apr 12, 2024

zroubalik mentioned this pull request Dec 16, 2024

InitialCooldownPeriod should be *int32 not int32 #6423

Closed

add InitialCooldownPeriod for ScaledObjects #5478

add InitialCooldownPeriod for ScaledObjects #5478

Uh oh!

Conversation

xrwang8 commented Feb 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

JorTurFer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

shubham-kaushal commented Feb 26, 2024

Uh oh!

JorTurFer commented Feb 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xrwang8 commented Feb 28, 2024

Uh oh!

xrwang8 commented Mar 4, 2024

Uh oh!

shubham-kaushal commented Mar 5, 2024

Uh oh!

JorTurFer commented Mar 12, 2024 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JorTurFer commented Mar 12, 2024

Uh oh!

xrwang8 commented Mar 13, 2024

Uh oh!

JorTurFer left a comment

Choose a reason for hiding this comment

Uh oh!

JorTurFer commented Mar 15, 2024 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JorTurFer commented Mar 15, 2024

Uh oh!

xrwang8 commented Mar 17, 2024

Uh oh!

xrwang8 commented Mar 18, 2024

Uh oh!

JorTurFer commented Mar 25, 2024

Uh oh!

JorTurFer left a comment

Choose a reason for hiding this comment

Uh oh!

xrwang8 commented Mar 26, 2024

Uh oh!

Uh oh!

JorTurFer commented Mar 26, 2024 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JorTurFer commented Mar 26, 2024

Uh oh!

xrwang8 commented Apr 2, 2024

Uh oh!

JorTurFer commented Apr 3, 2024

Uh oh!

aj-ya commented Apr 8, 2024

Uh oh!

Uh oh!

Uh oh!

xrwang8 commented Apr 11, 2024

Uh oh!

zroubalik commented Apr 11, 2024 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xrwang8 commented Apr 12, 2024

Uh oh!

Uh oh!

add `InitialCooldownPeriod` for ScaledObjects #5478

add `InitialCooldownPeriod` for ScaledObjects #5478

xrwang8 commented Feb 4, 2024 •

edited

Loading

JorTurFer commented Feb 26, 2024 •

edited

Loading

JorTurFer commented Mar 12, 2024 •

edited by github-actions bot

Loading

JorTurFer commented Mar 15, 2024 •

edited by github-actions bot

Loading

JorTurFer commented Mar 26, 2024 •

edited by github-actions bot

Loading

zroubalik commented Apr 11, 2024 •

edited by github-actions bot

Loading