Make sure PIWIK_DOCUMENT_ROOT gets defined #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, calling a frontend site fails with the following PHP error Use of undefined constant PIWIK_DOCUMENT_ROOT - assumed 'PIWIK_DOCUMENT_ROOT' (this will throw an Error in a future version of PHP) in piwik\core\Config.php on line 111 ... PHP Warning: require(PIWIK_DOCUMENT_ROOT/config/global.php): failed to open stream: No such file or directory in ... The problem is caused by matomo-org/matomo#14866 Make sure to define PIWIK_DOCUMENT_ROOT before it is used.
kaystrobach
approved these changes
Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
matomo-org/matomo#14866, which is part of Matomo 3.12 and 3.13, changes how constants are used by Matomo. Now PIWIK_DOCUMENT_ROOT needs to be defined manually for FE calls. Without this, calling a frontend site fails with the following PHP error:
Make sure to define PIWIK_DOCUMENT_ROOT before it is used.