Refactor verify command #864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extract verifyLoadBalancer method with AdvancedConfiguration support - Extract verifyVpcLatticeConfiguration method - Add verifyDeploymentConfiguration method with LifecycleHooks validation - Add Lambda client for lifecycle hook target verification - Improve code organization and readability 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add ErrPermissionDenied type and WARN result status - Implement isPermissionError to detect AWS permission errors - Add wrapPermissionError helper for cleaner error handling - Update verify functions to wrap permission errors appropriately - Support both direct APIError and OperationError-wrapped errors - Add comprehensive tests for permission error handling This allows verify to continue when encountering permission errors instead of failing completely, making it more usable in environments with restricted permissions. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Two improvements to the
verifycommand:verifyServiceDefinition- Extract verification logic into separate methods for better code organization[WARN]) so verify can continue in restricted IAM environmentsExample
When lacking Lambda permissions:
Previously this would fail the entire verify command. Now it shows a warning and continues.