-
Notifications
You must be signed in to change notification settings - Fork 1.2k
kata-types: remove default setting of guest_hook_path #11705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kata-types: remove default setting of guest_hook_path #11705
Conversation
To make it aligned with the setting of runtime-go, we should keep it as empty when users doesn't enable and set its specified path. Signed-off-by: Alex Lyn <alex.lyn@antgroup.com>
For future reference: kata-containers/src/runtime/pkg/katautils/config.go Lines 618 to 623 in 585d0be
and
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @Apokleos !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in aligning with the go runtime. Thanks!
To make it aligned with the setting of runtime-go, we should keep it as empty when users doesn't enable and set its specified path.
Signed-off-by: Alex Lyn alex.lyn@antgroup.com