Skip to content

Conversation

Apokleos
Copy link
Contributor

To make it aligned with the setting of runtime-go, we should keep it as empty when users doesn't enable and set its specified path.

Signed-off-by: Alex Lyn alex.lyn@antgroup.com

To make it aligned with the setting of runtime-go, we should keep
it as empty when users doesn't enable and set its specified path.

Signed-off-by: Alex Lyn <alex.lyn@antgroup.com>
@BbolroC
Copy link
Member

BbolroC commented Aug 20, 2025

For future reference:

func (h hypervisor) guestHookPath() string {
if h.GuestHookPath == "" {
return defaultGuestHookPath
}
return h.GuestHookPath
}

and

const defaultGuestHookPath string = ""

Copy link
Member

@BbolroC BbolroC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @Apokleos !

Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in aligning with the go runtime. Thanks!

@BbolroC BbolroC merged commit 0ac8f1f into kata-containers:main Aug 20, 2025
339 of 361 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants