Skip to content

mem-agent: Ignore Cargo.lock #11613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2025
Merged

mem-agent: Ignore Cargo.lock #11613

merged 1 commit into from
Jul 28, 2025

Conversation

RuoqingHe
Copy link
Member

@RuoqingHe RuoqingHe commented Jul 22, 2025 •
edited
Loading

mem-agent here is now a library and do not contain examples, ignore
Cargo.lock to get rid of untracked file noise produced by cargo run or
cargo test.

Signed-off-by: Ruoqing He heruoqing@iscas.ac.cn

@Apokleos
Copy link
Contributor

Hey Ruoqing @RuoqingHe, it seems duplicated with this PR

@RuoqingHe RuoqingHe closed this Jul 23, 2025
@RuoqingHe RuoqingHe reopened this Jul 23, 2025
@RuoqingHe RuoqingHe force-pushed the clippy-fix-for-libs-20250721 branch from 1b1ea28 to 18f0f7e Compare July 23, 2025 01:39
@RuoqingHe RuoqingHe changed the title libs: Fix clippy since bumped to Rust v1.85.1 mem-agent: Ignore Cargo.lock Jul 23, 2025
@RuoqingHe RuoqingHe marked this pull request as ready for review July 23, 2025 01:40
@RuoqingHe
Copy link
Member Author

Hey Ruoqing @RuoqingHe, it seems duplicated with this PR

Repurposed

Apokleos
Apokleos approved these changes Jul 23, 2025
View reviewed changes
Copy link
Contributor

@Apokleos Apokleos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @RuoqingHe LGTM!

@RuoqingHe RuoqingHe requested review from justxuewei and lifupan July 24, 2025 11:44
justxuewei
justxuewei approved these changes Jul 28, 2025
View reviewed changes
Copy link
Member

@justxuewei justxuewei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks!

@RuoqingHe @justxuewei
mem-agent: Ignore Cargo.lock
4ca6c2d 
`mem-agent` here is now a library and do not contain examples, ignore
Cargo.lock to get rid of untracked file noise produced by `cargo run` or
`cargo test`.

Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
@justxuewei justxuewei force-pushed the clippy-fix-for-libs-20250721 branch from 18f0f7e to 4ca6c2d Compare July 28, 2025 02:32
@justxuewei justxuewei merged commit 2a3c8b0 into kata-containers:main Jul 28, 2025
513 of 538 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justxuewei justxuewei justxuewei approved these changes

@Apokleos Apokleos Apokleos approved these changes

@lifupan lifupan Awaiting requested review from lifupan

Assignees
No one assigned
Labels
ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RuoqingHe @Apokleos @justxuewei @fidencio