runtime-rs: Add only static ARP entries with handle_neighours #11698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make it aligned with runtime-go, we need add only static ARP entries into the targets. Fixes kata-containers#11697 Signed-off-by: Alex Lyn <alex.lyn@antgroup.com>
stevenhorsman
approved these changes
Aug 19, 2025
| // We add only static ARP entries | ||
| let neighbors: Vec<ARPNeighbor> = all_neighbors | ||
| .iter() | ||
| .filter(|n| n.state == NUD_PERMANENT as i32) |
There was a problem hiding this comment.
For future reference I think this logic is replicating
kata-containers/src/runtime/virtcontainers/network_linux.go
Lines 1617 to 1620 in c92bb1a
BbolroC
approved these changes
Aug 19, 2025
danmihai1
approved these changes
Aug 19, 2025
Redent0r
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make it aligned with runtime-go, we need add only static ARP entries into the targets.
Fixes #11697