runtime-rs: Fix issues for initdata #11693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenhorsman
approved these changes
Aug 19, 2025
|
Hold on! We need to consider to go the test green for both go-runtime and runtime-rs. |
3634162 to
5c1cdca
Compare
5c1cdca to
114435c
Compare
|
I’ve renamed the title so we can track all initdata issues and continue the discussion here. I’d like to reach out to @burgerdev, @fitzthum, and @Xynnn007 for feedback on renaming the annotation. I will keep this as draft until we reach an agreement. |
… definition" This reverts commit ede773d. `cc_init_data` should be under a hypervisor category because it is a hypervisor-specific feature. The annotation including `runtime` also breaks a logic for `is_annotation_enabled()`. Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
This reverts commit 37685c4. This renames the relevant constant for initdata. Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
1c8bedf to
0daafec
Compare
burgerdev
approved these changes
Aug 20, 2025
stevenhorsman
added a commit
to stevenhorsman/cloud-api-adaptor
that referenced
this pull request
Aug 20, 2025
In kata-containers/kata-containers#11693 the initdata annotation changed, so update our code to reflect this Signed-off-by: stevenhorsman <steven@uk.ibm.com>
This was referenced Aug 21, 2025
stevenhorsman
added a commit
to stevenhorsman/cloud-api-adaptor
that referenced
this pull request
Aug 21, 2025
In kata-containers/kata-containers#11693 the initdata annotation changed, so update our code to reflect this Signed-off-by: stevenhorsman <steven@uk.ibm.com>
stevenhorsman
added a commit
to stevenhorsman/kata-containers
that referenced
this pull request
Aug 21, 2025
In kata-containers#11693 the cc_init_data annotation was changes to be hypervisor scoped, so each hypervisor needs to explicitly allow it in order to use it now, so add this to both the go and rust runtime's remote configurations Signed-off-by: stevenhorsman <steven@uk.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running the initdata test with runtime-rs, the following issues were identified:
"\[CDH\] \[ERROR\]: Get Resource failed"does not appear for runtime-rscc_init_datashould have been put inenable_annotationsin the configuration fileio.katacontainers.config.hypervisor.cc_init_datashould have been usedThis PR resolves the issues.
This will unblock a CI issue for #11447.
For details, please have a look at each commit message.
Signed-off-by: Alex Lyn alex.lyn@antgroup.com
Signed-off-by: Hyounggyu Choi Hyounggyu.Choi@ibm.com
FYI: @stevenhorsman @Apokleos