-
Notifications
You must be signed in to change notification settings - Fork 1.2k
ci: cri-containerd: add 5s timeout for creating sanbox with crictl #11669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After moving Arm64 CI nodes to new one, we do faced an interesting issue for timeout when it executes the command with crictl runp, the error is usally: code = DeadlineExceeded Fixes: kata-containers#11662 Signed-off-by: Kevin Zhao <kevin.zhao@linaro.org>
c9dde7e
to
1aa6516
Compare
fidencio
approved these changes
Aug 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @kevinzs2048!
And with this we have the ARM CI fully replaced! \o/
RuoqingHe
approved these changes
Aug 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @kevinzs2048 for tackling this ❤️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After moving Arm64 CI nodes to new
not powerful
one, we do faced an interesting issue for timeout when it executes the command withcrictl runp
, the error is usally: code = DeadlineExceededCloses: #11662