runtime-rs: add seccomp support for cloud hypervisor and firecracker #11536
+9
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justxuewei
reviewed
Jul 9, 2025
Comment on lines
+197
to
+200
| # Disable the 'seccomp' feature from Cloud Hypervisor or firecracker, default false | ||
| # disable_seccomp = true | ||
|
|
There was a problem hiding this comment.
I saw you added a test condition for seccomp in fc, but why is it absent in clh?
There was a problem hiding this comment.
This has been implemented in Cloud Hypervisor.
kata-containers/src/runtime-rs/crates/hypervisor/src/ch/inner_hypervisor.rs
Lines 358 to 360 in 294b2c1
The seccomp feature for Cloud Hypervisor and Firecracker is enabled by default. This commit introduces an option to disable seccomp for both and updates the built-in configuration.toml file accordingly. Fixes: kata-containers#11535 Signed-off-by: wangxinge <wangxinge@bupt.edu.cn>
38239f0 to
f3a669e
Compare
lifupan
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The seccomp feature for Cloud Hypervisor and Firecracker is enabled by default. This commit introduces an option to disable seccomp for both and updates the built-in configuration.toml file accordingly.
Fixes: #11535