Skip to content

tests: runtimeclasses: Adjust gpu runtimeclasses #11530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2025
Merged

tests: runtimeclasses: Adjust gpu runtimeclasses #11530

merged 1 commit into from
Jul 7, 2025

Conversation

fidencio
Copy link
Member

@fidencio fidencio commented Jul 7, 2025

679cc9d was merged and bumped the podoverhead for the gpu related runtimeclasses. However, the bump on the kata-runtimeClasses.yaml as overlooked, making our tests fail due to that discrepancy.

Let's just adjust the values here and move on.

@fidencio
tests: runtimeclasses: Adjust gpu runtimeclasses
2c2995b 
679cc9d was merged and bumped the
podoverhead for the gpu related runtimeclasses. However, the bump on the
`kata-runtimeClasses.yaml` as overlooked, making our tests fail due to
that discrepancy.

Let's just adjust the values here and move on.

Signed-off-by: Fabiano Fidêncio <fidencio@northflank.com>
@fidencio fidencio requested review from stevenhorsman and zvonkok July 7, 2025 09:45
@fidencio
Copy link
Member Author

fidencio commented Jul 7, 2025

@kata-containers/architecture-committee, we need to have the kata-deploy-runtime-classes-check test marked as required in order to avoid such issues in the future.

stevenhorsman
stevenhorsman approved these changes Jul 7, 2025
View reviewed changes
Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising the fix so quickly

@stevenhorsman
Copy link
Member

@kata-containers/architecture-committee, we need to have the kata-deploy-runtime-classes-check test marked as required in order to avoid such issues in the future.

I'll do that in github now

@fidencio
Copy link
Member Author

fidencio commented Jul 7, 2025

I'll do that in github now

Thanks, @stevenhorsman!

zvonkok
zvonkok approved these changes Jul 7, 2025
View reviewed changes
Copy link
Contributor

@zvonkok zvonkok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fidencio fidencio merged commit 110f68a into kata-containers:main Jul 7, 2025
509 of 539 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvonkok zvonkok zvonkok approved these changes

@stevenhorsman stevenhorsman stevenhorsman approved these changes

Assignees
No one assigned
Labels
ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fidencio @stevenhorsman @zvonkok