-
Notifications
You must be signed in to change notification settings - Fork 1.2k
runtime-rs: add initdata annotation for remote hypervisor #11528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @stevenhorsman @bpradipt @fidencio I found there's still a minor gap between runtime-go and runtime-rs on the annotation of initdata. PTAL. Really appreciate it! |
stevenhorsman
approved these changes
Jul 7, 2025
fidencio
approved these changes
Jul 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @Apokleos!
@Apokleos, I've rebased your branch atop of main, let's get the tests re-running. |
Add init data annotation within preparing remote hypervisor annotations when prepare vm, so that it can be passed within CreateVMRequest. Signed-off-by: alex.lyn <alex.lyn@antgroup.com>
dcf9176
to
fcaade2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add init data annotation within preparing remote hypervisor annotations when prepare vm, so that it can be passed within CreateVMRequest.
Signed-off-by: alex.lyn alex.lyn@antgroup.com