runtime: Fix rootlessDir not correctly set in rootless VMM mode #11527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@StevenFryto Commit message check throws the following error. I checked your commit using To append the correct S-o-b, execute |
4ce840c to
a033295
Compare
Thanks, I’ve updated the commit metadata as suggested. |
Previously, the rootlessDir variable in `src/runtime/virtcontainers/pkg/rootless.go` was initialized at
package load time using `os.Getenv("XDG_RUNTIME_DIR")`. However, in rootless
VMM mode, the correct value of $XDG_RUNTIME_DIR is set later during runtime
using os.Setenv(), so rootlessDir remained empty.
This patch defers the initialization of rootlessDir until the first call
to `GetRootlessDir()`, ensuring it always reflects the current environment
value of $XDG_RUNTIME_DIR.
Fixes: kata-containers#11526
Signed-off-by: stevenfryto <sunzitai_1832@bupt.edu.cn>
a033295 to
3c7a670
Compare
lifupan
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the rootlessDir variable in
src/runtime/virtcontainers/pkg/rootless.gowas initialized at package load time usingos.Getenv("XDG_RUNTIME_DIR"). However, in rootless VMM mode, the correct value of $XDG_RUNTIME_DIR is set later during runtime using os.Setenv(), so rootlessDir remained empty.This patch defers the initialization of rootlessDir until the first call to
GetRootlessDir(), ensuring it always reflects the current environment value of $XDG_RUNTIME_DIR.Fixes: #11526