-
Notifications
You must be signed in to change notification settings - Fork 1.2k
workflows: adopting azure/setup-kubectl #11523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d210d9e
to
72c82ce
Compare
There are workflows that rely on `az aks install-cli` to get kubectl installed. There is a well-known problem on install-cli, related with API usage rate limit, that has recently caused the command to fail quite often. This is replacing install-cli with the azure/setup-kubectl github action which has no such as rate limit problem. While here, removed the install_cli() function from gha-run-k8s-common.sh so avoid developers using it by mistake in the future. Fixes kata-containers#11463 Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
72c82ce
to
e4da3b8
Compare
Updated to pin the version to sha commit. Testing in https://github.com/kata-containers/kata-containers/actions/runs/16151195067 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming green tests.
As far as kubectl installation is concerned, tests are green. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @wainersm!
The stable tests in https://github.com/kata-containers/kata-containers/actions/runs/16151195067/job/45590114805 seem to be working, so as this is a workflow change I'll use admin rights to merge it. |
There are workflows that rely on
az aks install-cli
to get kubectl installed. There is a well-known problem on install-cli, related with API usage rate limit, that has recently caused the command to fail quite often.This is replacing install-cli with the azure/setup-kubectl github action which has no such as rate limit problem.
While here, removed the install_cli() function from gha-run-k8s-common.sh so avoid developers using it by mistake in the future.
Fixes #11463
I've tested this change here:
kubelogin
, which is downloaded by install-cli but not setup-kubectl, isn't used in our workflows. At least they didn't fail because of its lack.setup-kubectl akin to install-cli is going to find and install latest kubectl version.