Remove gpu admin tools #11567
Remove gpu admin tools #11567
Conversation
NVRC got a new feature reading the CC mode directly from register Signed-off-by: Zvonko Kaiser <zkaiser@nvidia.com>
New versions have incompatibilites, pin toolkit to a working version Signed-off-by: Zvonko Kaiser <zkaiser@nvidia.com>
| @@ -67,7 +67,7 @@ install_nvidia_ctk() { | |||
| echo "chroot: Installing NVIDIA GPU container runtime" | |||
| apt list nvidia-container-toolkit-base -a | |||
| # Base gives a nvidia-ctk and the nvidia-container-runtime | |||
| eval "${APT_INSTALL}" nvidia-container-toolkit-base | |||
| eval "${APT_INSTALL}" nvidia-container-toolkit-base=1.17.6-1 | |||
There was a problem hiding this comment.
This is a nit, but should this be added as part of versions.yaml?
There was a problem hiding this comment.
Yes and No we want to test always the latest version to see if things break, so essentially we do not care until it breaks, but may be a good thing to have it in the versions.yaml I haven't had a need for that, famous last words.
There was a problem hiding this comment.
Yeah, leave it out for now and we re-evaluate it after the release.
Fair?
There was a problem hiding this comment.
Does the package repo where this comes from keep old versions around? At least for the standard debian repos, I noticed that pinning packages like this only works for some time, but eventually the mirrors all drop the older versions. Maybe not a concern, because "we want to test always the latest version"?
| @@ -67,7 +67,7 @@ install_nvidia_ctk() { | |||
| echo "chroot: Installing NVIDIA GPU container runtime" | |||
| apt list nvidia-container-toolkit-base -a | |||
| # Base gives a nvidia-ctk and the nvidia-container-runtime | |||
| eval "${APT_INSTALL}" nvidia-container-toolkit-base | |||
| eval "${APT_INSTALL}" nvidia-container-toolkit-base=1.17.6-1 | |||
There was a problem hiding this comment.
Does the package repo where this comes from keep old versions around? At least for the standard debian repos, I noticed that pinning packages like this only works for some time, but eventually the mirrors all drop the older versions. Maybe not a concern, because "we want to test always the latest version"?
Remove gpu admin tools and pin toolkit version.