Skip to content

Conversation

fidencio
Copy link
Member

The /opt/kata/VERSION file, which is created using git describe --tags, requires the newly released tag to be updated in order to be accurate.

To do so, let's add a fetch-tags: true to the checkout action used during the create-kata-tarball job.

Copy link
Contributor

@zvonkok zvonkok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a ton @fidencio

Copy link
Member

@RuoqingHe RuoqingHe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, thanks @fidencio

@RuoqingHe RuoqingHe force-pushed the topic/fix-version-file-on-release branch from 2c31a9a to 74acdde Compare July 11, 2025 03:16
The `/opt/kata/VERSION` file, which is created using `git describe
--tags`, requires the newly released tag to be updated in order to be
accurate.

To do so, let's add a `fetch-tags: true` to the checkout action used
during the `create-kata-tarball` job.

Signed-off-by: Fabiano Fidêncio <fidencio@northflank.com>
@fidencio fidencio force-pushed the topic/fix-version-file-on-release branch from 74acdde to fb22e87 Compare July 11, 2025 07:47
@stevenhorsman
Copy link
Member

As a workflow only change, admin rights are needed to merge this as we can't/don't test this change in the PR ci

@stevenhorsman stevenhorsman merged commit 878e50f into kata-containers:main Jul 11, 2025
30 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants