runtime-rs: Add vfio support with coldplug for cloud-hypervisor #11540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dd510dc to
8d3bf1b
Compare
lifupan
approved these changes
Jul 9, 2025
RuoqingHe
reviewed
Jul 10, 2025
| @@ -185,8 +185,7 @@ impl CloudHypervisorInner { | |||
| } | |||
|
|
|||
| async fn boot_vm(&mut self) -> Result<()> { | |||
| let (shared_fs_devices, network_devices) = self.get_shared_devices().await?; | |||
|
|
|||
| let (shared_fs_devices, network_devices, host_devices) = self.get_shared_devices().await?; | |||
There was a problem hiding this comment.
IMO we should put this line into the previous commit, otherwise the build breaks if we bisect onto the first commit, write like let (shared_fs_devices, network_devices, _) = self.get_shared_devices().await?; to silence the warnings
And we change _ to host_devices here in the second commit
There was a problem hiding this comment.
good catch ! thx for this suggestion. fixed
This PR adds support for adding a vfio device before starting the cloud-hypervisor VM (or cold-plug vfio device). This commit changes "pending_devices" for clh implementation via adding DeviceType::Vfio() into pending_devices. And it will get shared host devices after correctly handling vfio devices (Specially for primary device). Signed-off-by: alex.lyn <alex.lyn@antgroup.com> Signed-off-by: Fupan Li <fupan.lfp@antgroup.com>
This commit introduce `host_devices` to help convert vfio devices from a generic hypervisor config to a cloud-hypervisor specific VmConfig. Signed-off-by: alex.lyn <alex.lyn@antgroup.com> Signed-off-by: Fupan Li <fupan.lfp@antgroup.com>
This PR adds support for adding a network device before starting the cloud-hypervisor VM. This commit will get the host devices from NamedHypervisorConfig and assign it to VmConfig's devices which is for vfio devices when clh starts launching. And with this, it successfully finish the vfio devices conversion from a generic Hypervisor config to a clh specific VmConfig. Signed-off-by: alex.lyn <alex.lyn@antgroup.com> Signed-off-by: Fupan Li <fupan.lfp@antgroup.com>
8d3bf1b to
3fbe493
Compare
RuoqingHe
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runtime-rs: Add vfio support with coldplug for cloud-hypervisor
This PR adds support for adding a vfio device before starting the
cloud-hypervisor VM (or cold-plug vfio device).
In certain high-performance scenarios, users require direct network
device passthrough to achieve superior network performance within
Kata Containers. In Kata's networking model, device passthrough is
facilitated through VFIO , and we need to implement support for this.
Signed-off-by: alex.lyn alex.lyn@antgroup.com
Signed-off-by: Fupan Li fupan.lfp@antgroup.com