nvidia-rootfs: only copy kata-opa if AGENT_POLICY is enabled
#11407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0100d90 to
86feae9
Compare
86feae9 to
8c22c7b
Compare
danmihai1
approved these changes
Jun 10, 2025
fidencio
reviewed
Jun 11, 2025
| @@ -15,6 +15,7 @@ readonly SCRIPT_DIR="${script_dir}/nvidia" | |||
| # This will control how much output the inird/image will produce | |||
| DEBUG="" | |||
| KBUILD_SIGN_PIN=${KBUILD_SIGN_PIN:-} | |||
| AGENT_POLICY=${AGENT_POLICY:-} | |||
There was a problem hiding this comment.
@Champ-Goblem, just for the sake of consistency with what we have as part of the other rootfs scripts ...
Could you sete the default policy here to "no"?
Suggested change
| AGENT_POLICY=${AGENT_POLICY:-} | |
| AGENT_POLICY="${AGENT_POLICY:-no}" |
There was a problem hiding this comment.
I've fixed this and force-pushed to your branch, @Champ-Goblem!
In the nvidia rootfs build, only copy in `kata-opa` if `AGENT_POLICY` is enabled. This fixes builds when `AGENT_POLICY` is disabled and opa is not built. Signed-off-by: Champ-Goblem <cameron@northflank.com>
8c22c7b to
d6c4502
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the nvidia rootfs build, only copy in
kata-opaifAGENT_POLICYis enabled. This fixes builds whenAGENT_POLICYis disabled and opa is not built.