Skip to content

gha: Eliminate use of force-skip-ci label #11499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2025
Merged

gha: Eliminate use of force-skip-ci label #11499

merged 1 commit into from
Jul 2, 2025

Conversation

sprt
Copy link
Contributor

@sprt sprt commented Jul 1, 2025 •
edited
Loading

Please see commit message.

@sprt sprt requested review from stevenhorsman and fidencio July 1, 2025 18:43
Apokleos
Apokleos approved these changes Jul 2, 2025
View reviewed changes
Copy link
Contributor

@Apokleos Apokleos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm for it. LGTM!

RuoqingHe
RuoqingHe approved these changes Jul 2, 2025
View reviewed changes
Copy link
Member

@RuoqingHe RuoqingHe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, thanks @sprt ❤️

@stevenhorsman
Copy link
Member

Should we just expand this to remove force-skip-ci from all our workflows? I was originally implemented as a skip in the jenkins configuration, and after this PR the only workflows that would be skipped are the cargo-deny (which is a bit broken and needs some work anyway) and WIP check, which is another very cheap flow.

@sprt
gha: Eliminate use of force-skip-ci label
8d7d859 
This was originally implemented as a Jenkins skip and is only used in a few
workflows.  Nowadays this would be better implemented via the gatekeeper.

Signed-off-by: Aurélien Bombo <abombo@microsoft.com>
@sprt sprt force-pushed the sprt/fix-commit-check branch from 6d9b6d6 to 8d7d859 Compare July 2, 2025 15:32
@sprt
Copy link
Contributor Author

sprt commented Jul 2, 2025

Should we just expand this to remove force-skip-ci from all our workflows? I was originally implemented as a skip in the jenkins configuration, and after this PR the only workflows that would be skipped are the cargo-deny (which is a bit broken and needs some work anyway) and WIP check, which is another very cheap flow.

Yes, done!

@sprt sprt changed the title gha: Don't skip commit message check with force-skip-ci gha: Eliminate use of force-skip-ci label Jul 2, 2025
stevenhorsman
stevenhorsman approved these changes Jul 2, 2025
View reviewed changes
Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@sprt sprt merged commit 8d86bce into main Jul 2, 2025
38 of 51 checks passed
@sprt sprt deleted the sprt/fix-commit-check branch July 2, 2025 15:53
@sprt
Copy link
Contributor Author

sprt commented Jul 2, 2025

Force-merged as workflow-only change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenhorsman stevenhorsman stevenhorsman approved these changes

@Apokleos Apokleos Apokleos approved these changes

@RuoqingHe RuoqingHe RuoqingHe approved these changes

@fidencio fidencio Awaiting requested review from fidencio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sprt @stevenhorsman @Apokleos @RuoqingHe