-
Notifications
You must be signed in to change notification settings - Fork 1.2k
runtime-rs: Set default_maxvcpus to 0 #11469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime-rs: Set default_maxvcpus to 0 #11469
Conversation
Otherwise we just cannot start a container that requests more than 1 vcpu. Signed-off-by: Fabiano Fidêncio <fidencio@northflank.com>
@BbolroC, any chance to help me figuring out why s390x is failing due to this change here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx, it will make max vcpus default value align with other vmms.
LGTM.
Resolved. Thanks for your patience! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Otherwise we just cannot start a container that requests more than 1 vcpu.