Skip to content

Sev deprecation #11380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 9, 2025
Merged

Sev deprecation #11380

merged 4 commits into from
Jul 9, 2025

Conversation

arvindskumar99
Copy link
Contributor

This PR is continuing from where @AdithyaKrishnan left off in 11070 for the SEV deprecation from kata.

@wainersm wainersm self-requested a review June 4, 2025 16:24
@arvindskumar99 arvindskumar99 force-pushed the sev-deprecation branch 3 times, most recently from 83e87a4 to dc64293 Compare June 5, 2025 18:45
stevenhorsman
stevenhorsman requested changes Jun 6, 2025
View reviewed changes
@stevenhorsman stevenhorsman marked this pull request as draft June 6, 2025 08:21
@Apokleos
Copy link
Contributor

Apokleos commented Jun 9, 2025

Thx @arvindskumar99 I think this code changes is so large. My main concern about the deprecated action is its backgroud and the deprecation plan.

@mythi
Copy link
Contributor

mythi commented Jun 9, 2025

My main concern about the deprecated action is its backgroud and the deprecation plan.

@Apokleos see #10840 for details. AFAUI, the plan was: announce deprecation and remove after two releases.

@Apokleos
Copy link
Contributor

Apokleos commented Jun 10, 2025 •
edited
Loading

My main concern about the deprecated action is its backgroud and the deprecation plan.

@Apokleos see #10840 for details. AFAUI, the plan was: announce deprecation and remove after two releases.

Thx Mikko @mythi Yeah, I think the issue is what I'd like to see.

@arvindskumar99 arvindskumar99 force-pushed the sev-deprecation branch 2 times, most recently from 0f7afb2 to 8e45d05 Compare June 10, 2025 17:57
@Apokleos
Copy link
Contributor

As this deprecation plan in WIP, whether should we also do this work in runtime-rs ? what do you think @pmores

stevenhorsman
stevenhorsman requested changes Jun 11, 2025
View reviewed changes
Copy link
Member

@stevenhorsman stevenhorsman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is frustrating as I'm re-doing the same reviews from the previous PR and you've missed a bunch of things that were in that code. Please ensure you check through it yourself again

@pmores
Copy link
Contributor

pmores commented Jun 11, 2025

As this deprecation plan in WIP, whether should we also do this work in runtime-rs ? what do you think @pmores

Agreed, and it should be a much smaller change in runtime-rs too I guess. However I think we'd better merge #10968 first to complete SNP functionality. An SEV deprecation PR would likely conflict with #10968, and I assume finishing required functionality is more important than removing deprecated functionality anyway.

@arvindskumar99 arvindskumar99 force-pushed the sev-deprecation branch 3 times, most recently from f978b68 to 705ffdf Compare June 11, 2025 20:28
@Apokleos
Copy link
Contributor

As this deprecation plan in WIP, whether should we also do this work in runtime-rs ? what do you think @pmores

Agreed, and it should be a much smaller change in runtime-rs too I guess. However I think we'd better merge #10968 first to complete SNP functionality. An SEV deprecation PR would likely conflict with #10968, and I assume finishing required functionality is more important than removing deprecated functionality anyway.

sure @pmores , make the required function done first and move it forward.

zvonkok
zvonkok reviewed Jun 12, 2025
View reviewed changes
tools/packaging/kata-deploy/local-build/kata-deploy-binaries.sh Outdated
@@ -436,6 +436,7 @@ install_image_confidential() {

#Install cbl-mariner guest image
install_image_mariner() {
export IMAGE_SIZE_ALIGNMENT_MB=2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this related to the SEV removal?

Copy link
Contributor Author

@arvindskumar99 arvindskumar99 Jun 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zvonkok, not sure how that change got pulled into this PR, I think there was a mix up with the files that Adi had shared with me and some previous PR. I went ahead and reverted it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zvonkok Do you have any other comments on this PR?

stevenhorsman
stevenhorsman reviewed Jun 12, 2025
View reviewed changes
@arvindskumar99 arvindskumar99 force-pushed the sev-deprecation branch 2 times, most recently from b1391b9 to fd03004 Compare June 16, 2025 04:48
stevenhorsman
stevenhorsman requested changes Jun 16, 2025
View reviewed changes
@arvindskumar99 arvindskumar99 force-pushed the sev-deprecation branch 2 times, most recently from bbc36a0 to ef7b395 Compare June 17, 2025 04:33
stevenhorsman
stevenhorsman approved these changes Jun 17, 2025
View reviewed changes
Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. Thanks for the updates

@stevenhorsman stevenhorsman marked this pull request as ready for review June 17, 2025 09:58
arvindskumar99 and others added 4 commits July 7, 2025 11:17
@arvindskumar99 @AdithyaKrishnan
kata-deploy: Removing SEV from kata-deploy
675ea86 
Removing files related to SEV, responsible for
installing and configuring Kata containers.

Co-authored-by: Adithya Krishnan Kannan <AdithyaKrishnan.Kannan@amd.com>
Signed-off-by: Arvind Kumar <arvinkum@amd.com>
@arvindskumar99 @AdithyaKrishnan
tests: Removing testing framework for SEV
8eebcef 
Removing files pertaining to SEV from
the CI framework.

Co-authored-by: Adithya Krishnan Kannan <AdithyaKrishnan.Kannan@amd.com>
Signed-off-by: Arvind Kumar <arvinkum@amd.com>
@arvindskumar99 @AdithyaKrishnan
runtime: Removing runtime logic for SEV
ecac3d2 
Removing runtime SEV functionality,
such as the kbs, ovmf, VMSA handling,
and SEV configs as part of deprecating
SEV from kata.

Co-authored-by: Adithya Krishnan Kannan <AdithyaKrishnan.Kannan@amd.com>
Signed-off-by: Arvind Kumar <arvinkum@amd.com>
@arvindskumar99 @AdithyaKrishnan
kernel: Removing SEV kernel packages
afedad0 
Removing kernel config files realting
to SEV as part of the SEV deprecation
efforts.

Co-authored-by: Adithya Krishnan Kannan <AdithyaKrishnan.Kannan@amd.com>
Signed-off-by: Arvind Kumar <arvinkum@amd.com>
@stevenhorsman stevenhorsman merged commit 967f66f into kata-containers:main Jul 9, 2025
748 of 812 checks passed
arvindskumar99 added a commit to arvindskumar99/kata-containers that referenced this pull request Jul 11, 2025
@arvindskumar99
OVMF: deprecating SEV logic from OVMF
6402209 
Follow up PR for PR kata-containers#11380. Continuing deprecation
of SEV from Kata by removing references from the
OVMF.

Signed-off-by: Arvind Kumar <arvinkum@amd.com>
@arvindskumar99 arvindskumar99 mentioned this pull request Jul 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvonkok zvonkok zvonkok approved these changes

@stevenhorsman stevenhorsman stevenhorsman approved these changes

@wainersm wainersm Awaiting requested review from wainersm

Assignees
No one assigned
Labels
ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@arvindskumar99 @Apokleos @mythi @pmores @stevenhorsman @zvonkok