Upgrade ttrpc-codegen and protobuf to kill #![allow(box_pointers)]
#11376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous version of `ttrpc-codegen` is generating outdated `#![allow(box_pointers)]` which was deprecated. Bump `ttrpc-codegen` from v0.4.2 to v0.5.0 and `protobuf` from vx to v3.7.1 to get rid of this. Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
Removed unnecessary dynamic dispatch for services. Properly dereferenced service Box values and stored in Arc. Co-authored-by: Ruoqing He <heruoqing@iscas.ac.cn> Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn> Signed-Off-By: Ryan Savino <ryan.savino@amd.com>
Propagate `ttrpc-codegen` upgrade from `libs/protocols` to `agent`. Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
0f8104a
into
kata-containers:main
1196 of 1327 checks passed
RuoqingHe
added a commit
to RuoqingHe/kata-containers
that referenced
this pull request
Jun 9, 2025
Bump `ttrpc-codegen` related dependencies in response to `ttrpc-codegen` bump in `libs/protocol`. Relates: kata-containers#11376 Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
RuoqingHe
added a commit
to RuoqingHe/kata-containers
that referenced
this pull request
Jun 9, 2025
Bump `ttrpc-codegen` related dependencies in response to `ttrpc-codegen` bump in `libs/protocol`. Relates: kata-containers#11376 Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
RuoqingHe
added a commit
to RuoqingHe/kata-containers
that referenced
this pull request
Jun 9, 2025
Bump `ttrpc-codegen` related dependencies in response to `ttrpc-codegen` bump in `libs/protocol`. Relates: kata-containers#11376 Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
RuoqingHe
added a commit
to RuoqingHe/kata-containers
that referenced
this pull request
Jun 9, 2025
Bump `ttrpc-codegen` related dependencies in response to `ttrpc-codegen` bump in `libs/protocol`. Relates: kata-containers#11376 Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
RuoqingHe
added a commit
to RuoqingHe/kata-containers
that referenced
this pull request
Jun 9, 2025
Bump `ttrpc-codegen` related dependencies in response to `ttrpc-codegen` bump in `libs/protocol`. Relates: kata-containers#11376 Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
RuoqingHe
added a commit
to RuoqingHe/kata-containers
that referenced
this pull request
Jun 9, 2025
Bump `ttrpc-codegen` related dependencies in response to `ttrpc-codegen` bump in `libs/protocol`. Relates: kata-containers#11376 Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
RuoqingHe
added a commit
to RuoqingHe/kata-containers
that referenced
this pull request
Jun 9, 2025
Bump `ttrpc-codegen` related dependencies in response to `ttrpc-codegen` bump in `libs/protocol`. Relates: kata-containers#11376 Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
RuoqingHe
added a commit
to RuoqingHe/kata-containers
that referenced
this pull request
Jun 9, 2025
Bump `ttrpc-codegen` related dependencies in response to `ttrpc-codegen` bump in `libs/protocol`. Relates: kata-containers#11376 Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
RuoqingHe
added a commit
to RuoqingHe/kata-containers
that referenced
this pull request
Jun 9, 2025
Bump `ttrpc-codegen` related dependencies in response to `ttrpc-codegen` bump in `libs/protocol`. Relates: kata-containers#11376 Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
RuoqingHe
added a commit
to RuoqingHe/kata-containers
that referenced
this pull request
Jun 9, 2025
Bump `ttrpc-codegen` related dependencies in response to `ttrpc-codegen` bump in `libs/protocol`. Relates: kata-containers#11376 Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
RuoqingHe
added a commit
to RuoqingHe/kata-containers
that referenced
this pull request
Jun 9, 2025
Bump `ttrpc-codegen` related dependencies in response to `ttrpc-codegen` bump in `libs/protocol`. Relates: kata-containers#11376 Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
RuoqingHe
added a commit
to RuoqingHe/kata-containers
that referenced
this pull request
Jun 9, 2025
Bump `ttrpc-codegen` related dependencies in response to `ttrpc-codegen` bump in `libs/protocol`. Relates: kata-containers#11376 Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
RuoqingHe
added a commit
to RuoqingHe/kata-containers
that referenced
this pull request
Jun 10, 2025
Bump `ttrpc-codegen` related dependencies in response to `ttrpc-codegen` bump in `libs/protocol`. Relates: kata-containers#11376 Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
RuoqingHe
added a commit
to RuoqingHe/kata-containers
that referenced
this pull request
Jun 10, 2025
Bump `ttrpc-codegen` related dependencies in response to `ttrpc-codegen` bump in `libs/protocol`. Relates: kata-containers#11376 Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
RuoqingHe
added a commit
to RuoqingHe/kata-containers
that referenced
this pull request
Jun 10, 2025
Bump `ttrpc-codegen` related dependencies in response to `ttrpc-codegen` bump in `libs/protocol`. Relates: kata-containers#11376 Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
RuoqingHe
added a commit
to RuoqingHe/kata-containers
that referenced
this pull request
Jun 10, 2025
Bump `ttrpc-codegen` related dependencies in response to `ttrpc-codegen` bump in `libs/protocol`. Relates: kata-containers#11376 Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
RuoqingHe
added a commit
to RuoqingHe/kata-containers
that referenced
this pull request
Jun 11, 2025
Bump `ttrpc-codegen` related dependencies in response to `ttrpc-codegen` bump in `libs/protocol`. Relates: kata-containers#11376 Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
RuoqingHe
added a commit
to RuoqingHe/kata-containers
that referenced
this pull request
Jun 11, 2025
Bump `ttrpc-codegen` related dependencies in response to `ttrpc-codegen` bump in `libs/protocol`. Relates: kata-containers#11376 Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
RuoqingHe
added a commit
to RuoqingHe/kata-containers
that referenced
this pull request
Jun 11, 2025
Bump `ttrpc-codegen` related dependencies in response to `ttrpc-codegen` bump in `libs/protocol`. Relates: kata-containers#11376 Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
RuoqingHe
added a commit
to RuoqingHe/kata-containers
that referenced
this pull request
Jun 11, 2025
Bump `ttrpc-codegen` related dependencies in response to `ttrpc-codegen` bump in `libs/protocol`. Relates: kata-containers#11376 Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
RuoqingHe
added a commit
to RuoqingHe/kata-containers
that referenced
this pull request
Jun 11, 2025
Bump `ttrpc-codegen` related dependencies in response to `ttrpc-codegen` bump in `libs/protocol`. Relates: kata-containers#11376 Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
RuoqingHe
added a commit
to RuoqingHe/kata-containers
that referenced
this pull request
Jun 11, 2025
Bump `ttrpc-codegen` related dependencies in response to `ttrpc-codegen` bump in `libs/protocol`. Relates: kata-containers#11376 Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
RuoqingHe
added a commit
to RuoqingHe/kata-containers
that referenced
this pull request
Jun 11, 2025
Bump `ttrpc-codegen` related dependencies in response to `ttrpc-codegen` bump in `libs/protocol`. Relates: kata-containers#11376 Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
RuoqingHe
added a commit
to RuoqingHe/kata-containers
that referenced
this pull request
Jun 11, 2025
Bump `ttrpc-codegen` related dependencies in response to `ttrpc-codegen` bump in `libs/protocol`. Relates: kata-containers#11376 Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
RuoqingHe
added a commit
to RuoqingHe/kata-containers
that referenced
this pull request
Jun 11, 2025
Bump `ttrpc-codegen` related dependencies in response to `ttrpc-codegen` bump in `libs/protocol`. Relates: kata-containers#11376 Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
RuoqingHe
added a commit
to RuoqingHe/kata-containers
that referenced
this pull request
Jun 11, 2025
Bump `ttrpc-codegen` related dependencies in response to `ttrpc-codegen` bump in `libs/protocol`. Relates: kata-containers#11376 Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
RuoqingHe
added a commit
to RuoqingHe/kata-containers
that referenced
this pull request
Jun 11, 2025
Bump `ttrpc-codegen` related dependencies in response to `ttrpc-codegen` bump in `libs/protocol`. Relates: kata-containers#11376 Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
RuoqingHe
added a commit
to RuoqingHe/kata-containers
that referenced
this pull request
Jun 11, 2025
Bump `ttrpc-codegen` related dependencies in response to `ttrpc-codegen` bump in `libs/protocol`. Relates: kata-containers#11376 Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
RuoqingHe
added a commit
to RuoqingHe/kata-containers
that referenced
this pull request
Jun 11, 2025
Bump `ttrpc-codegen` related dependencies in response to `ttrpc-codegen` bump in `libs/protocol`. Relates: kata-containers#11376 Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
RuoqingHe
added a commit
to RuoqingHe/kata-containers
that referenced
this pull request
Jun 11, 2025
Bump `ttrpc-codegen` related dependencies in response to `ttrpc-codegen` bump in `libs/protocol`. Relates: kata-containers#11376 Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
RuoqingHe
added a commit
to RuoqingHe/kata-containers
that referenced
this pull request
Jun 11, 2025
Bump `ttrpc-codegen` related dependencies in response to `ttrpc-codegen` bump in `libs/protocol`. Relates: kata-containers#11376 Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
RuoqingHe
added a commit
to RuoqingHe/kata-containers
that referenced
this pull request
Jun 11, 2025
Bump `ttrpc-codegen` related dependencies in response to `ttrpc-codegen` bump in `libs/protocol`. Relates: kata-containers#11376 Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
RuoqingHe
added a commit
to RuoqingHe/kata-containers
that referenced
this pull request
Jun 11, 2025
Bump `ttrpc-codegen` related dependencies in response to `ttrpc-codegen` bump in `libs/protocol`. Relates: kata-containers#11376 Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous version of
ttrpc-codegen(v0.4.2) is generating rust code with#![allow(box_pointers)]which was deprecated and preventing us from bumping to Rust 1.85.1.Bump
ttrpc-codegenfrom v0.4.2 to v0.5.0 andprotobuffrom vx to v3.7.1 to get rid of this.Relates: #11305