kernel: Add CONFIG_TUN (needed for VPNs) and move mem-agent related configs to common #11344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
portersrc
approved these changes
May 30, 2025
There was a problem hiding this comment.
This is great! CONFIG_TUN=y is the only kernel config change I needed for the nebula work
TUN/TAP is a must for VPN related services. Signed-off-by: Champ-Goblem <cameron@northflank.com> Signed-off-by: Fabiano Fidêncio <fidencio@northflank.com>
There's no benefit on keeping those restricted to the dragonball build, when they can be used with other VMMs as well (as long as they support the mem-agent). Signed-off-by: Fabiano Fidêncio <fidencio@northflank.com>
d0d5ff3 to
dadbfd4
Compare
ananos
approved these changes
Jun 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TUN/TAP is commonly used with any kind of VPN services, so we should really have it enabled by default.
The mem-agent related configs should also be in common, instead of being part of the dragonball-experimental kernel ... as any VMM / runtime that supports mem-agent can take advantage of those.