Skip to content

gpu: Set the ARCH explicilty for driver builds #11228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2025
Merged

gpu: Set the ARCH explicilty for driver builds #11228

merged 1 commit into from
May 1, 2025

Conversation

zvonkok
Copy link
Contributor

@zvonkok zvonkok commented May 1, 2025

Kernel Makefiles changed how to deduce the right arch lets set it explicilty to enable arm and amd builds.

@katacontainersbot katacontainersbot added the size/tiny Smallest and simplest task label May 1, 2025
fidencio
fidencio approved these changes May 1, 2025
View reviewed changes
Copy link
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @zvonkok!

This allows me to move forward with #11227.

stevenhorsman
stevenhorsman approved these changes May 1, 2025
View reviewed changes
Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@zvonkok
gpu: Set the ARCH explicilty for driver builds
445cad7 
Kernel Makefiles changed how to deduce the right arch
lets set it explicilty to enable arm and amd builds.

Signed-off-by: Zvonko Kaiser <zkaiser@nvidia.com>
@zvonkok zvonkok force-pushed the fix-kernel-modules-build branch from cef08b6 to 445cad7 Compare May 1, 2025 17:16
@fidencio fidencio merged commit 7e404dd into kata-containers:main May 1, 2025
369 of 381 checks passed
@stevenhorsman
Copy link
Member

It looks like this might be failing the arm builds:

Makefile:90: *** Unsupported architecture aarch64.  Stop.
Failed at 172: chroot . /bin/bash -c "/nvidia_chroot.sh $(uname -r) ${run_file_name} 		${run_fm_file_name} ${machine_arch} ${NVIDIA_GPU_STACK} ${KBUILD_SIGN_PIN}"

?

@fidencio
Copy link
Member

fidencio commented May 2, 2025

@stevenhorsman, this PR was exactly to fix the issue you're pointing out. A rebase may be needed.

@stevenhorsman
Copy link
Member

stevenhorsman commented May 2, 2025 •
edited
Loading

@stevenhorsman, this PR was exactly to fix the issue you're pointing out. A rebase may be needed.

Ah - my bad. Thanks for the correction. I didn't see this issue before the PR - do we not have the kernel pinned properly or something that lead to this?

@zvonkok zvonkok deleted the fix-kernel-modules-build branch June 9, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fidencio fidencio fidencio approved these changes

@stevenhorsman stevenhorsman stevenhorsman approved these changes

Assignees
No one assigned
Labels
ok-to-test size/tiny Smallest and simplest task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zvonkok @stevenhorsman @fidencio @katacontainersbot