agent: netlink: Only add an ipv6 address if ipv6 is enabled #11227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b8ad13f to
d38ecc1
Compare
stevenhorsman
approved these changes
May 1, 2025
d38ecc1 to
11d3a41
Compare
lifupan
reviewed
May 2, 2025
11d3a41 to
49dbf02
Compare
When running Kata Containers on CSPs, the CSPs may enforce their
clusters to be IPv4-only.
Checking the OCI spec passed down to container, on a GKE cluster, we can
see:
```
"sysctl": {
...
"net.ipv6.conf.all.disable_ipv6": "1",
"net.ipv6.conf.default.disable_ipv6": "1",
...
},
```
Even with ipv6 being explicitly disabled (behind our back ;-)), we've
noticed that IPv6 addresses would be received, but then as IPv6 was
disabled we'd break on CreatePodSandbox with the following error:
```
Warning FailedCreatePodSandBox 4s kubelet Failed to
create pod sandbox: rpc error: code = Unknown desc = failed to create
containerd task: failed to create shim task: "update interface: Failed
to add address fe80::c44c:1cff:fe84:f6b7: NetlinkError(ErrorMessage {
code: Some(-13), header: [64, 0, 0, 0, 20, 0, 5, 5, 19, 0, 0, 0, 0, 0,
0, 0, 10, 64, 0, 0, 2, 0, 0, 0, 20, 0, 1, 0, 254, 128, 0, 0, 0, 0, 0, 0,
196, 76, 28, 255, 254, 132, 246, 183, 20, 0, 2, 0, 254, 128, 0, 0, 0, 0,
0, 0, 196, 76, 28, 255, 254, 132, 246, 183] })\n\nStack backtrace:\n
0: <unknown>\n 1: <unknown>\n 2: <unknown>\n 3: <unknown>\n 4:
<unknown>\n 5: <unknown>\n 6: <unknown>\n 7: <unknown>\n 8:
<unknown>\n 9: <unknown>\n 10: <unknown>": unknown
```
A huge shoutout to Fupan Li for helping with the debug on this one!
Fixes: kata-containers#11200
Signed-off-by: Fabiano Fidêncio <fidencio@northflank.com>
49dbf02 to
4ce00ea
Compare
lifupan
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running Kata Containers on CSPs, the CSPs may enforce their clusters to be IPv4-only.
Checking the OCI spec passed down to container, on a GKE cluster, we can see:
Even with ipv6 being explicitly disabled (behind our back ;-)), we've noticed that IPv6 addresses would be received, but then as IPv6 was disabled we'd break on CreatePodSandbox with the following error:
A huge shoutout to Fupan Li for helping with the debug on this one!
Fixes: #11200