Runtime rs centralise workspace config #11217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42032ea to
5005cbc
Compare
693dcdb to
0e9f995
Compare
f49bc86 to
131ddbc
Compare
As discussed in kata-containers#9538, with anyhow >=1.0.77 we have test failures due to backtrace behaviour changing, so set RUST_LIB_BACKTRACE=0, so that we only have backtrace on panics Signed-off-by: stevenhorsman <steven@uk.ibm.com>
Update the runtime-rs workspace packages to use workspace package versions where applicable to centralise the config and reduce maintenance when updating these Signed-off-by: stevenhorsman <steven@uk.ibm.com>
131ddbc to
a126884
Compare
|
I'm happy to rebase this on #11131 if it's merged first, but I think this can be reviewed now as all the tests seem to be passing. The only package I couldn't unify was nix - we have three different versions as when I tried to just pick a single one we got a bunch of incompatibilities, so I've left them separated for now. |
fidencio
approved these changes
May 1, 2025
RuoqingHe
approved these changes
May 1, 2025
There was a problem hiding this comment.
Great work, we are one-step closer to a consistent workspace 😄, thanks @stevenhorsman
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the runtime-rs workspace packages to
use workspace package versions where applicable
to centralise the config and reduce maintenance
when updating these