dragonball: Remove package lockfiles #11211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lifupan
approved these changes
Apr 30, 2025
RuoqingHe
approved these changes
Apr 30, 2025
There was a problem hiding this comment.
Great work, thanks for taking care of this @stevenhorsman ❤️, clearly this is something should be done along with the workspace change
|
It looks like some genpolicy PRs have come in, which is causing the SNP test failures, so I will try rebasing |
Since kata-containers#10780 the dbs crates are managed as members of the dragonball workspace, so we can remove the lockfile as it's now workspace managed now Signed-off-by: stevenhorsman <steven@uk.ibm.com>
a68f330 to
97f7d49
Compare
When a PR has no new files the cargo deny runner fails with: ``` [cargo-deny-generator.sh:17] ERROR: changed_files_status= ``` so add `|| true` to try and help this Co-authored-by: Ruoqing He <heruoqing@iscas.ac.cn> Signed-off-by: stevenhorsman <steven@uk.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #10780 the dbs crates are managed as members of the dragonball workspace, so we can remove the lockfile as it's now workspace managed now