Skip to content

Conversation

lifupan
Copy link
Member

@lifupan lifupan commented Apr 29, 2025

It's better to open the log pipe file with read & write option, otherwise, once the containerd reboot and closed the read endpoint, kata shim would write the log pipe with broken pipe error.

Fixes: #11207

@katacontainersbot katacontainersbot added the size/tiny Smallest and simplest task label Apr 29, 2025
Copy link
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @lifupan!

It's better to open the log pipe file with read & write option,
otherwise, once the containerd reboot and closed the read
endpoint, kata shim would write the log pipe with broken pipe error.

Fixes: kata-containers#11207

Signed-off-by: Fupan Li <fupan.lfp@antgroup.com>
@katacontainersbot katacontainersbot added size/large Task of significant size and removed size/tiny Smallest and simplest task labels May 1, 2025
@katacontainersbot katacontainersbot added size/tiny Smallest and simplest task and removed size/large Task of significant size labels May 1, 2025
@justxuewei justxuewei merged commit a9b3c6a into kata-containers:main May 2, 2025
327 of 466 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test size/tiny Smallest and simplest task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

runtime-rs shim prrocess would panic when containerd reboot
4 participants