-
Notifications
You must be signed in to change notification settings - Fork 1.2k
versions: Bump golang.org/x/net #11204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
versions: Bump golang.org/x/net #11204
Conversation
90120fe
to
815915d
Compare
src/runtime/pkg/katautils/hook.go
Outdated
@@ -136,7 +136,7 @@ func PreStartHooks(ctx context.Context, spec specs.Spec, cid, bundlePath string) | |||
return nil | |||
} | |||
|
|||
return runHooks(ctx, spec, spec.Hooks.Prestart, cid, bundlePath, "pre-start") | |||
return runHooks(ctx, spec, spec.Hooks.CreateRuntime, cid, bundlePath, "pre-start") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/pre-start/create-runtime/ ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've swapped it to I decided that at that point I might as well route the call to createRuntime
#consistencyCreateRuntimeHooks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest that maybe the whole PreStartHooks
should be removed, but I don't understand the hooks well enough to make that call
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the docker tests are failing now - which I think was where I got stuck last time I tried this 😞. I'm not sure whether to just ignore the deprecation warning for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just ignore the deprecation warning for now, please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'll do that on a follow up PR. Thanks
2c3e12b
to
d0f003a
Compare
Bump golang.org/x/net to 0.38.0 as dependabot isn't doing it for these packages to remediate CVE-2025-22872 Signed-off-by: stevenhorsman <steven@uk.ibm.com>
d0f003a
to
ed3cb65
Compare
I'm going to split out the runc bump for now to see if that helps the stability of the testing. |
ed3cb65
to
bcffe93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @stevenhorsman!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me @stevenhorsman ❤️
Bump golang.org/x/net to 0.38.0 as dependabot
isn't doing it for these packages to remediate
GHSA-vvgc-356p-c3xw