tests/k8s: delint confidential_kbs.sh #11294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The shellcheck action has caught some extra warnings that running locally didn't. I will address these too: |
Addressed the following shellcheck advices: SC2046 (warning): Quote this to prevent word splitting. SC2248 (style): Prefer double quoting even when variables don't contain special characters SC2250 (style): Prefer putting braces around variable references even when not strictly required. SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Although the script will inherit that setting from the caller scripts, expliciting it in the file will vanish shellcheck "warning: Use 'pushd ... || exit' or 'pushd ... || return' in case pushd fails. [SC2164]" Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Fixed "warning: HKD_PATH is referenced but not assigned. [SC2154]" Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
2660376 to
c9fb0b9
Compare
|
Added two commits to address #11294 (comment) although I am not able to have shellcheck to emit that warnings neither in VSCode nor running shellcheck (version 0.10.0, fedora packaged) |
Fixed "note: Not following: ./../../../tools/packaging/guest-image/lib_se.sh: openBinaryFile: does not exist (No such file or directory) [SC1091]" Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
|
one more commit and it's free of shellcheck complains \o/ |
stevenhorsman
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed the following shellcheck advices:
SC2046 (warning): Quote this to prevent word splitting.
SC2248 (style): Prefer double quoting even when variables don't contain special characters
SC2250 (style): Prefer putting braces around variable references even when not strictly required.
SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh
Resulting in a free of warning/info/style file.
I have fixed some stuffs on that file recently and seeing the shellcheck advices was making me sick, hence this PR that I hope doesn't introduce unintentional bugs (always are a risk).