Skip to content

Conversation

fidencio
Copy link
Member

@fidencio fidencio commented May 9, 2025

The previous attempt to fix this issue only took in consideration the QEMU binary, as I completely forgot that there were other pieces of the config that we also adjusted.

Now, let's just check one of the configs before trying to adjust anything else, and only do the changes if the suffix added with the multi-install suffix is not yet added.

@katacontainersbot katacontainersbot added the size/small Small and simple task label May 9, 2025
The previous attempt to fix this issue only took in consideration the
QEMU binary, as I completely forgot that there were other pieces of the
config that we also adjusted.

Now, let's just check one of the configs before trying to adjust
anything else, and only do the changes if the suffix added with the
multi-install suffix is not yet added.{

Signed-off-by: Fabiano Fidêncio <fidencio@northflank.com>
@fidencio fidencio force-pushed the topic/second-try-fix-multi-install-prefix branch from 4d14a30 to 82928d1 Compare May 14, 2025 13:42
Copy link
Contributor

@zvonkok zvonkok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested with several restarts and workload execution, works as expected!

Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks reasonable and Zvonko did the due diligence to check this, so LGTM (let's get this merged)

@fidencio fidencio merged commit af3c601 into kata-containers:main May 15, 2025
335 of 350 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test size/small Small and simple task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants