runtime-rs: fix vfio pci address domain 0001 problem #11254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For NUMA I need similar functionality, let me cross-check with my POC and see if we can get on the same dominator. |
|
This is tested with Dragonball? |
As I know that it might be CLH |
|
Please run rustfmt against your codes. |
done |
RuoqingHe
reviewed
May 23, 2025
Comment on lines
697
to
699
| let Some(domain_part) = parts.first() else { | ||
| return None; | ||
| }; |
There was a problem hiding this comment.
clippy is not happy of this writing here, would you mind running make check under src/runtime-rs to fix the clippy warnings 🙂
Some nvidia gpu pci address domain with 0001, current runtime default deal with 0000:bdf, which cause address errors during device initialization and address conflicts during device registration. Fixes kata-containers#11252 Signed-off-by: yangsong <yunya.ys@antgroup.com>
lifupan
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some nvidia gpu pci address domain with 0001,
current runtime default deal with 0000:bdf,
which cause address errors during device initialization and address conflicts during device registration