Skip to content

Conversation

stevenhorsman
Copy link
Member

@stevenhorsman stevenhorsman commented May 9, 2025

Update module to remediate CVE-2025-22868

Copy link
Contributor

@burgerdev burgerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linked CVE is for Traefik, we might want to link https://pkg.go.dev/vuln/GO-2025-3488 instead.

@gkurz
Copy link
Member

gkurz commented May 13, 2025

The linked CVE is for Traefik, we might want to link https://pkg.go.dev/vuln/GO-2025-3488 instead.

Right or/and https://www.cve.org/CVERecord?id=CVE-2025-22868 if we want to advertise a more generic CVE id (might be easier for downstream).

Please update both the commit and PR description @stevenhorsman .

Update module to remediate
[CVE-2025-22868](https://www.cve.org/CVERecord?id=CVE-2025-22868)

Signed-off-by: stevenhorsman <steven@uk.ibm.com>
@stevenhorsman stevenhorsman force-pushed the golang.org/x/oauth2v0.27.0-bump branch from 499fef5 to b382582 Compare May 13, 2025 10:01
@stevenhorsman
Copy link
Member Author

The linked CVE is for Traefik, we might want to link https://pkg.go.dev/vuln/GO-2025-3488 instead.

That's weird. I just added the CVE number (which is correct). It's github that chooses to render it as a hyperlink that points to the wrong thing (the Traefik record), so I don't think what I did was incorrect?

Copy link
Member

@gkurz gkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linked CVE is for Traefik, we might want to link https://pkg.go.dev/vuln/GO-2025-3488 instead.

That's weird. I just added the CVE number (which is correct). It's github that chooses to render it as a hyperlink that points to the wrong thing (the Traefik record), so I don't think what I did was incorrect?

Yeah you're doing right and GH is definitely doing wrong : they should have a more appropriate link for the CVE record and the UI should be smart enough to not render the text part within an explicit link 😉

Thanks @stevenhorsman !

Copy link
Member

@RuoqingHe RuoqingHe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stevenhorsman for tackling this, while I start to wonder if we could reduce the diffs every time vendor of golang changes (perhaps put it into a git submodule 🧐?)

@RuoqingHe RuoqingHe merged commit 2681979 into kata-containers:main May 13, 2025
329 of 361 checks passed
@stevenhorsman stevenhorsman deleted the golang.org/x/oauth2v0.27.0-bump branch June 11, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test size/tiny Smallest and simplest task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants