agent: Allow users to build without guest-pull #11114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7d9247a to
e1d030f
Compare
stevenhorsman
approved these changes
Apr 4, 2025
danmihai1
approved these changes
Apr 4, 2025
sprt
reviewed
Apr 4, 2025
src/agent/Cargo.toml
Outdated
| @@ -100,7 +100,7 @@ lto = true | |||
|
|
|||
| [features] | |||
| # The default-pull feature would support all pull types, including sharing images by virtio-fs and pulling images in the guest | |||
There was a problem hiding this comment.
Need to change this comment as well
For those not interested in CoCo, let's at least allow them to easily build the agent without the guest-pull feature. This reduces the binary size (already stripped) from 25M to 18M. Signed-off-by: Fabiano Fidêncio <fabiano@fidencio.org>
e1d030f to
e3c98a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For those not interested in CoCo, let's at least allow them to easily build the agent without the guest-pull feature.
This reduces the binary size (already stripped) from 25M to 18M.