-
Notifications
You must be signed in to change notification settings - Fork 1.2k
ci.ocp: Add peer-pods setup script #10940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ldoktor !
I checked locally some instructions but I could not run the entire script due lack of time. As you managed to run it on openshift-ci with a fork, it should be fine.
I learned some nice stuffs here. E.g. peerring between regions! Cool!
Hi Lukas ! I cannot really provide an efficient review on the OCP CI and Azure specific parts but the evidences you provide are enough for me. I'll just focus on more cosmetic but yet important details like making sure that shellcheck is happy. Thanks for your effort. |
Changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks @ldoktor !
Hi @ldoktor ! Could you please rebase to get the CI jobs running again? |
this script will be used in a new OCP integration pipeline to monitor basic workflows of OCP+peer-pods. Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
No changes, just rebase |
Hi @ldoktor , I do not understand why some jobs aren't triggered in this PR. |
This is because I'm only touching |
hey @stevenhorsman , could you please use your superpowers to push it? |
this script will be used in a new OCP integration pipeline to monitor basic workflows of OCP+peer-pods.
Testing version of this pipeline can be found here: openshift/release#61457 using this file provided as gist https://gist.github.com/ldoktor/a7a3c797a53304ef91c58ed8cee416af. Once this is merged I'll switch that to this file instead and propose it for merging.