Skip to content

Conversation

ldoktor
Copy link
Contributor

@ldoktor ldoktor commented Feb 26, 2025

this script will be used in a new OCP integration pipeline to monitor basic workflows of OCP+peer-pods.

Testing version of this pipeline can be found here: openshift/release#61457 using this file provided as gist https://gist.github.com/ldoktor/a7a3c797a53304ef91c58ed8cee416af. Once this is merged I'll switch that to this file instead and propose it for merging.

@katacontainersbot katacontainersbot added the size/large Task of significant size label Feb 26, 2025
Copy link
Contributor

@wainersm wainersm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ldoktor !

I checked locally some instructions but I could not run the entire script due lack of time. As you managed to run it on openshift-ci with a fork, it should be fine.

I learned some nice stuffs here. E.g. peerring between regions! Cool!

@gkurz
Copy link
Member

gkurz commented Mar 18, 2025

Hi Lukas !

I cannot really provide an efficient review on the OCP CI and Azure specific parts but the evidences you provide are enough for me. I'll just focus on more cosmetic but yet important details like making sure that shellcheck is happy.

Thanks for your effort.

@ldoktor
Copy link
Contributor Author

ldoktor commented Apr 2, 2025

Changes:

  • rebased
  • extra warning at the beginning of the file about required manual resources cleanup
  • addressed all issues spotted by Greg

Copy link
Member

@gkurz gkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks @ldoktor !

@wainersm
Copy link
Contributor

Hi @ldoktor ! Could you please rebase to get the CI jobs running again?

this script will be used in a new OCP integration pipeline to monitor
basic workflows of OCP+peer-pods.

Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
@ldoktor
Copy link
Contributor Author

ldoktor commented Apr 15, 2025

No changes, just rebase

@wainersm
Copy link
Contributor

Hi @ldoktor , I do not understand why some jobs aren't triggered in this PR.

@ldoktor
Copy link
Contributor Author

ldoktor commented Apr 29, 2025

This is because I'm only touching ci/openshift-tests so gatekeeper knows this PR can not make those tests to fail and skips them. Unfortunately the GH required tests don't see that so we need some maintainer to force-merge this. Note GK passed as all required jobs are fine ;-)

@wainersm
Copy link
Contributor

This is because I'm only touching ci/openshift-tests so gatekeeper knows this PR can not make those tests to fail and skips them. Unfortunately the GH required tests don't see that so we need some maintainer to force-merge this. Note GK passed as all required jobs are fine ;-)

hey @stevenhorsman , could you please use your superpowers to push it?

@stevenhorsman stevenhorsman merged commit a6d1dc7 into kata-containers:main Apr 29, 2025
199 of 205 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/large Task of significant size
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants