-
Notifications
You must be signed in to change notification settings - Fork 1.2k
local-build: Do not build measured rootfs on s390x #10841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
local-build: Do not build measured rootfs on s390x #10841
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @BbolroC!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @BbolroC!
IBM SE ensures to make initrd measured by genprotimg and verified by ultravisor. Let's not build the measured rootf on s390x. Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
bb4e646
to
d5db47b
Compare
Update: I got an error below while building
I've put the same conditional in |
Let's skip all tests for trusted storage until kata-containers#10838 is resolved. Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
d5db47b
to
1bdb34e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
The tests for trusted storage have started failing for I've updated the PR to skip the affected tests based on the platform rather than |
IBM SE has encountered a boot failure issue since the guest OS was upgraded to Ubuntu 22.04. We identified that the issue is caused by the initramfs, which is built for the measured rootfs scenario. IBM SE ensures that the initrd is measured by genprotimg and verified by the ultravisor. To address this, let’s skip building the measured rootfs on s390x. This PR also skips end-to-end tests for trusted storage for IBM SE.
For reviewers: the changes are already verified at https://github.com/kata-containers/kata-containers/actions/runs/13150558902/job/36740406368
Signed-off-by: Hyounggyu Choi Hyounggyu.Choi@ibm.com
FYI: @hbrueckner