Skip to content

Conversation

BbolroC
Copy link
Member

@BbolroC BbolroC commented Feb 5, 2025

IBM SE has encountered a boot failure issue since the guest OS was upgraded to Ubuntu 22.04. We identified that the issue is caused by the initramfs, which is built for the measured rootfs scenario. IBM SE ensures that the initrd is measured by genprotimg and verified by the ultravisor. To address this, let’s skip building the measured rootfs on s390x. This PR also skips end-to-end tests for trusted storage for IBM SE.

For reviewers: the changes are already verified at https://github.com/kata-containers/kata-containers/actions/runs/13150558902/job/36740406368

Signed-off-by: Hyounggyu Choi Hyounggyu.Choi@ibm.com

FYI: @hbrueckner

@BbolroC BbolroC requested a review from fidencio February 5, 2025 18:48
@katacontainersbot katacontainersbot added the size/small Small and simple task label Feb 5, 2025
Copy link
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @BbolroC!

Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @BbolroC!

IBM SE ensures to make initrd measured by genprotimg and verified by ultravisor.
Let's not build the measured rootf on s390x.

Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
@BbolroC BbolroC force-pushed the make-measured-rootfs-configurable branch from bb4e646 to d5db47b Compare February 6, 2025 09:13
@BbolroC
Copy link
Member Author

BbolroC commented Feb 6, 2025

Update: I got an error below while building shim-v2-tarball:

INFO: Enable rootfs measurement config
ERROR: Root hash file for measured rootfs not found at /home/ansible/gha-runner/_layout/_work/kata-containers/kata-containers/tools/packaging/kata-deploy/local-build/build/root_hash.txt

I've put the same conditional in install_shimv2() to make sure that the measured rootfs is not set on s390x.

Let's skip all tests for trusted storage until kata-containers#10838 is resolved.

Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
Copy link
Contributor

@hbrueckner hbrueckner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm

@BbolroC
Copy link
Member Author

BbolroC commented Feb 6, 2025

The tests for trusted storage have started failing for qemu-coco-dev without the measured rootfs. It was caused by the same reason reported in #10838. k8s-measured-rootfs.bats has also started failing.

I've updated the PR to skip the affected tests based on the platform rather than KATA_HYPERVISOR. Further investigation will be carried out in a separate PR. Thanks.

@BbolroC BbolroC merged commit 48c5b1f into kata-containers:main Feb 6, 2025
285 of 298 checks passed
@BbolroC BbolroC deleted the make-measured-rootfs-configurable branch February 6, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test size/small Small and simple task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants