-
Notifications
You must be signed in to change notification settings - Fork 1.2k
versions: Bump trustee to latest #10730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This update addresses an issue with token verification for SE and SNP introduced in the last update by kata-containers#10541. Bumping the project to the latest commit resolves the issue. Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, 🫰
btw it would be good to spin this one on SNP since we have a fix for that platform cc @ryansavino @AdithyaKrishnan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @BbolroC!
I'm adding a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, tests are passing on tdx.
Thanks @BbolroC!
adding the |
For a little more detail, the last bump had two small bugs in it that affected s390x and SNP. We didn't look very closely at the s390x CI on the PR and the SNP CI was broken. Choi and I debugged the s390x issue and realized that SNP might have a similar problem. Fortunately it was easy to fix, but we have yet to run the SNP stuff through the CI with the fix (or without it). Ideally we can get this PR to run on the SNP CI, but if we can't get that working in the next day or so we could test it locally or just take a leap of faith (it is probably fixed now but who knows). |
Considering the SNP machine has not been working for almost a month or so, let's give it till Tomorrow beginning of my day, and then we have it merged. Although I agree it'd be good to have it tested on all platforms, it doesn't make sense to block a fix for s390x / coco-non-tee waiting for the CI that has been majoritarely down / broken for way too long. |
btw @ryansavino @AdithyaKrishnan we should still try to get a CI run (on any PR) or a local test before the release comes out at the very least to see where we stand |
snp node is back up and the job passed for this PR. |
- Bump guest-components to sync up with kata-containers/kata-containers#10541 - Bump trustee to sync with kata-containers/kata-containers#10730 - Bump kata-agent to pick up the a commit that includes both these bumps for testing. Signed-off-by: stevenhorsman <steven@uk.ibm.com>
- Bump guest-components to sync up with kata-containers/kata-containers#10541 - Bump trustee to sync with kata-containers/kata-containers#10730 - Bump kata-agent to pick up the 3.13.0 release that includes both of these Signed-off-by: stevenhorsman <steven@uk.ibm.com>
- Bump guest-components to sync up with kata-containers/kata-containers#10541 - Bump trustee to sync with kata-containers/kata-containers#10730 - Bump kata-agent to pick up the 3.13.0 release that includes both of these Signed-off-by: stevenhorsman <steven@uk.ibm.com>
- Bump guest-components to sync up with kata-containers/kata-containers#10541 - Bump trustee to sync with kata-containers/kata-containers#10730 - Bump kata-agent to pick up the 3.13.0 release that includes both of these Signed-off-by: stevenhorsman <steven@uk.ibm.com>
- Bump guest-components to sync up with kata-containers/kata-containers#10541 - Bump trustee to sync with kata-containers/kata-containers#10730 - Bump kata-agent to pick up the 3.13.0 release that includes both of these Signed-off-by: stevenhorsman <steven@uk.ibm.com>
- Bump guest-components to sync up with kata-containers/kata-containers#10541 - Bump trustee to sync with kata-containers/kata-containers#10730 - Bump kata-agent to pick up the 3.13.0 release that includes both of these Signed-off-by: stevenhorsman <steven@uk.ibm.com>
This update addresses an issue with token verification for SE and SNP introduced in the last update by #10541.
Bumping the project to the latest commit resolves the issue.
Signed-off-by: Hyounggyu Choi Hyounggyu.Choi@ibm.com