Skip to content

Conversation

BbolroC
Copy link
Member

@BbolroC BbolroC commented Jan 13, 2025

This update addresses an issue with token verification for SE and SNP introduced in the last update by #10541.
Bumping the project to the latest commit resolves the issue.

Signed-off-by: Hyounggyu Choi Hyounggyu.Choi@ibm.com

This update addresses an issue with token verification for SE and SNP
introduced in the last update by kata-containers#10541.
Bumping the project to the latest commit resolves the issue.

Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
@BbolroC BbolroC requested a review from fitzthum January 13, 2025 14:08
@katacontainersbot katacontainersbot added the size/tiny Smallest and simplest task label Jan 13, 2025
Copy link
Contributor

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zvonkok zvonkok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 🫰

@fitzthum
Copy link
Contributor

btw it would be good to spin this one on SNP since we have a fix for that platform cc @ryansavino @AdithyaKrishnan

Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @BbolroC!

@fidencio fidencio added the do-not-merge PR has problems or depends on another label Jan 13, 2025
@fidencio
Copy link
Member

I'm adding a do-not-merge label till I can get the TDX machine back up and running, and I will merge it as soon as this also passes there.

@fidencio fidencio removed the do-not-merge PR has problems or depends on another label Jan 13, 2025
Copy link
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, tests are passing on tdx.

Thanks @BbolroC!

@fidencio
Copy link
Member

btw it would be good to spin this one on SNP since we have a fix for that platform cc @ryansavino @AdithyaKrishnan

adding the do-not-merge label again due to this.

@fidencio fidencio added the do-not-merge PR has problems or depends on another label Jan 13, 2025
@fitzthum
Copy link
Contributor

For a little more detail, the last bump had two small bugs in it that affected s390x and SNP. We didn't look very closely at the s390x CI on the PR and the SNP CI was broken. Choi and I debugged the s390x issue and realized that SNP might have a similar problem.

Fortunately it was easy to fix, but we have yet to run the SNP stuff through the CI with the fix (or without it). Ideally we can get this PR to run on the SNP CI, but if we can't get that working in the next day or so we could test it locally or just take a leap of faith (it is probably fixed now but who knows).

@fidencio
Copy link
Member

For a little more detail, the last bump had two small bugs in it that affected s390x and SNP. We didn't look very closely at the s390x CI on the PR and the SNP CI was broken. Choi and I debugged the s390x issue and realized that SNP might have a similar problem.

Fortunately it was easy to fix, but we have yet to run the SNP stuff through the CI with the fix (or without it). Ideally we can get this PR to run on the SNP CI, but if we can't get that working in the next day or so we could test it locally or just take a leap of faith (it is probably fixed now but who knows).

Considering the SNP machine has not been working for almost a month or so, let's give it till Tomorrow beginning of my day, and then we have it merged.

Although I agree it'd be good to have it tested on all platforms, it doesn't make sense to block a fix for s390x / coco-non-tee waiting for the CI that has been majoritarely down / broken for way too long.

@fidencio fidencio removed the do-not-merge PR has problems or depends on another label Jan 14, 2025
@fidencio
Copy link
Member

As the SNP node is down, we're proceeding to merge this PR as agreed before.

image

@fidencio fidencio merged commit 4578969 into kata-containers:main Jan 14, 2025
803 of 830 checks passed
@BbolroC BbolroC deleted the bump-coco-trustee branch January 14, 2025 08:06
@fitzthum
Copy link
Contributor

fitzthum commented Jan 14, 2025

btw @ryansavino @AdithyaKrishnan we should still try to get a CI run (on any PR) or a local test before the release comes out at the very least to see where we stand

@ryansavino
Copy link
Member

ryansavino commented Jan 14, 2025

snp node is back up and the job passed for this PR.

stevenhorsman added a commit to stevenhorsman/cloud-api-adaptor that referenced this pull request Jan 15, 2025
- Bump guest-components to sync up with
kata-containers/kata-containers#10541
- Bump trustee to sync with
kata-containers/kata-containers#10730
- Bump kata-agent to pick up the a commit that
includes both these bumps for testing.

Signed-off-by: stevenhorsman <steven@uk.ibm.com>
stevenhorsman added a commit to stevenhorsman/cloud-api-adaptor that referenced this pull request Jan 16, 2025
- Bump guest-components to sync up with
kata-containers/kata-containers#10541
- Bump trustee to sync with
kata-containers/kata-containers#10730
- Bump kata-agent to pick up the 3.13.0
release that includes both of these

Signed-off-by: stevenhorsman <steven@uk.ibm.com>
stevenhorsman added a commit to stevenhorsman/cloud-api-adaptor that referenced this pull request Jan 17, 2025
- Bump guest-components to sync up with
kata-containers/kata-containers#10541
- Bump trustee to sync with
kata-containers/kata-containers#10730
- Bump kata-agent to pick up the 3.13.0
release that includes both of these

Signed-off-by: stevenhorsman <steven@uk.ibm.com>
stevenhorsman added a commit to stevenhorsman/cloud-api-adaptor that referenced this pull request Jan 17, 2025
- Bump guest-components to sync up with
kata-containers/kata-containers#10541
- Bump trustee to sync with
kata-containers/kata-containers#10730
- Bump kata-agent to pick up the 3.13.0
release that includes both of these

Signed-off-by: stevenhorsman <steven@uk.ibm.com>
stevenhorsman added a commit to stevenhorsman/cloud-api-adaptor that referenced this pull request Jan 17, 2025
- Bump guest-components to sync up with
kata-containers/kata-containers#10541
- Bump trustee to sync with
kata-containers/kata-containers#10730
- Bump kata-agent to pick up the 3.13.0
release that includes both of these

Signed-off-by: stevenhorsman <steven@uk.ibm.com>
stevenhorsman added a commit to confidential-containers/cloud-api-adaptor that referenced this pull request Jan 17, 2025
- Bump guest-components to sync up with
kata-containers/kata-containers#10541
- Bump trustee to sync with
kata-containers/kata-containers#10730
- Bump kata-agent to pick up the 3.13.0
release that includes both of these

Signed-off-by: stevenhorsman <steven@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test size/tiny Smallest and simplest task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants